From: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Masami Hiramatsu <masami.hiramatsu@linaro.org>
Subject: ASoC: About graph node issue without 'reg' property
Date: Thu, 13 Dec 2018 19:39:45 +0900 [thread overview]
Message-ID: <20181213193944.CCC9.4A936039@socionext.com> (raw)
Hello Morimoto-san, Mark,
I found that your commit b6f3fc005a2c ("ASoC: simple-card-utils:
fixup asoc_simple_card_get_dai_id() counting") replaced with
of_graph_parse_endpoint(), that needs 'reg' property in each port
that has an endpoint.
Currently devicetrees for UniPhier SoCs have also audio graph nodes [1],
and these graph nodes include an endpoint for each port.
Although the port doesn't have 'reg' property, it has worked fine before.
And after applying the commit, it doesn't work.
It is written in Documentation/devicetree/bindings/graph.txt
that common scheme is to include the 'reg' property.
Maybe I think that we'd better add 'reg' properties to each port,
however, there might be same matter in other SoCs, so I'm not sure
whether your patch breaks the backword compatibility or
our devicetrees are wrong.
I'd be glad if I could hear something about this issue from you.
Thank you,
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi#n348
---
Best Regards,
Kunihiko Hayashi
next reply other threads:[~2018-12-13 10:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 10:39 Kunihiko Hayashi [this message]
2018-12-13 16:24 ` Mark Brown
2018-12-13 18:27 ` Mark Brown
2018-12-14 0:05 ` Kuninori Morimoto
2018-12-14 2:13 ` Kunihiko Hayashi
2018-12-17 0:47 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213193944.CCC9.4A936039@socionext.com \
--to=hayashi.kunihiko@socionext.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu@linaro.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®