From: David Miller <davem@davemloft.net>
To: fw@strlen.de
Cc: christophe.gouault@6wind.com, linux@stwm.de,
herbert@gondor.apana.org.au, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, steffen.klassert@secunet.com
Subject: Re: INFO: rcu detected stall in xfrm_hash_rebuild
Date: Fri, 14 Dec 2018 11:07:05 -0800 (PST) [thread overview]
Message-ID: <20181214.110705.1283167545212637328.davem@davemloft.net> (raw)
In-Reply-To: <20181214162333.utlut746n3butkuf@breakpoint.cc>
From: Florian Westphal <fw@strlen.de>
Date: Fri, 14 Dec 2018 17:23:33 +0100
> Christophe Gouault <christophe.gouault@6wind.com> wrote:
>> The main use cases I have encountered and tried to address with the
>> hash-based lookup were network operator use cases:
>> - a lot of dynamic /32 <=> /32 policies (protecting GTP tunnels)
>> - or a lot of dynamic policies with the same prefix lengths (e.g. /16 <=> /24)
>> and a few non-hashed policies stored in the linked list.
>
> Thanks for the detailed information.
>
> [..]
>
>> Could you verify how the configuration time would behave in such use
>> cases if the hash-based lookup was replaced by a tree-based lookup?
>
> I won't send a patch to remove your work, at least not at this time.
>
> In case I'd do this removal (thresholds, hash table, or both)
> i will make these tests to see how large the impact is.
Florian, thanks for working so hard on this.
The operational feedback is absolutely essential for figuring out how
to move forward on this issue, otherwise we'll just keep going back
and forth on the approach.
prev parent reply other threads:[~2018-12-14 19:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 7:50 syzbot
2018-12-10 12:47 ` Florian Westphal
2018-12-10 17:58 ` David Miller
2018-12-14 13:11 ` Wolfgang Walter
2018-12-14 14:35 ` Florian Westphal
2018-12-14 14:56 ` Herbert Xu
2018-12-14 16:04 ` Christophe Gouault
2018-12-14 16:23 ` Florian Westphal
2018-12-14 16:28 ` Christophe Gouault
2018-12-14 19:07 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181214.110705.1283167545212637328.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=christophe.gouault@6wind.com \
--cc=fw@strlen.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@stwm.de \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®