mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com,
	lipeng321@huawei.com, tanhuazhong@huawei.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hns3: prevent building without CONFIG_INET
Date: Fri, 14 Dec 2018 13:20:44 -0800 (PST)	[thread overview]
Message-ID: <20181214.132044.183096780468259380.davem@davemloft.net> (raw)
In-Reply-To: <20181210204448.2338398-1-arnd@arndb.de>

From: Arnd Bergmann <arnd@arndb.de>
Date: Mon, 10 Dec 2018 21:44:34 +0100

> We now get a link failure when CONFIG_INET is disabled, since
> tcp_gro_complete is unavailable:
> 
> drivers/net/ethernet/hisilicon/hns3/hns3_enet.o: In function `hns3_set_gro_param':
> hns3_enet.c:(.text+0x230c): undefined reference to `tcp_gro_complete'
> 
> Add an explicit CONFIG_INET dependency here to avoid the broken
> configuration.
> 
> Fixes: a6d53b97a2e7 ("net: hns3: Adds GRO params to SKB for the stack")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied.

      reply	other threads:[~2018-12-14 21:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-10 20:44 Arnd Bergmann
2018-12-14 21:20 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181214.132044.183096780468259380.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lipeng321@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=salil.mehta@huawei.com \
    --cc=tanhuazhong@huawei.com \
    --cc=yisen.zhuang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®