From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65ADBC43387 for ; Fri, 14 Dec 2018 21:23:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 984DE2080F for ; Fri, 14 Dec 2018 21:23:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731130AbeLNVXC (ORCPT ); Fri, 14 Dec 2018 16:23:02 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:33874 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730869AbeLNVXB (ORCPT ); Fri, 14 Dec 2018 16:23:01 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id F075614E088C5; Fri, 14 Dec 2018 13:23:00 -0800 (PST) Date: Fri, 14 Dec 2018 13:23:00 -0800 (PST) Message-Id: <20181214.132300.832860946069084294.davem@davemloft.net> To: arnd@arndb.de Cc: mcuos.com@gmail.com, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] w90p910_ether: remove incorrect __init annotation From: David Miller In-Reply-To: <20181210204514.2362328-1-arnd@arndb.de> References: <20181210204514.2362328-1-arnd@arndb.de> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 14 Dec 2018 13:23:01 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Mon, 10 Dec 2018 21:45:07 +0100 > The get_mac_address() function is normally inline, but when it is > not, we get a warning that this configuration is broken: > > WARNING: vmlinux.o(.text+0x4aff00): Section mismatch in reference from the function w90p910_ether_setup() to the function .init.text:get_mac_address() > The function w90p910_ether_setup() references > the function __init get_mac_address(). > This is often because w90p910_ether_setup lacks a __init > > Remove the __init to make it always do the right thing. > > Signed-off-by: Arnd Bergmann Actually I think we can validly mark w90p910_ether_setup() and w90p910_probe() with appropriate init tagging. None of these functions are invoked outside of the probing paths.