From: David Miller <davem@davemloft.net>
To: semen.protsenko@linaro.org
Cc: jchapman@katalix.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, g.nault@alphalink.fr
Subject: Re: [PATCH] l2tp: Add protocol field decompression
Date: Sat, 15 Dec 2018 23:28:59 -0800 (PST) [thread overview]
Message-ID: <20181215.232859.365899686560746192.davem@davemloft.net> (raw)
In-Reply-To: <20181214175921.6859-1-semen.protsenko@linaro.org>
From: Sam Protsenko <semen.protsenko@linaro.org>
Date: Fri, 14 Dec 2018 19:59:21 +0200
> When Protocol Field Compression (PFC) is enabled, the "Protocol" field
> in PPP packet will be received without leading 0x00. See section 6.5 in
> RFC 1661 for details. So let's decompress protocol field if needed, the
> same way it's done in drivers/net/ppp/pptp.c.
>
> In case when "nopcomp" pppd option is not enabled, PFC (pcomp) can be
> negotiated during LCP handshake, and L2TP driver in kernel will receive
> PPP packets with compressed Protocol field, which in turn leads to next
> error:
>
> Protocol Rejected (unsupported protocol 0x2145)
>
> because instead of Protocol=0x0021 in PPP packet there will be
> Protocol=0x21. This patch unwraps it back to 0x0021, which fixes the
> issue.
>
> Sending the compressed Protocol field will be implemented in subsequent
> patch, this one is self-sufficient.
>
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
Applied, thanks.
next prev parent reply other threads:[~2018-12-16 7:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 17:59 Sam Protsenko
2018-12-16 7:28 ` David Miller [this message]
2018-12-16 16:29 ` Guillaume Nault
2018-12-16 18:36 ` Sam Protsenko
2018-12-16 19:17 ` Guillaume Nault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181215.232859.365899686560746192.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=g.nault@alphalink.fr \
--cc=jchapman@katalix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=semen.protsenko@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®