From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0477C43444 for ; Fri, 14 Dec 2018 16:14:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1B1672070B for ; Fri, 14 Dec 2018 16:14:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544804061; bh=NB2kLxGcTz9is7Ml+siasg03+/uxiCXHIAVl8N494ZE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=ictfwh+mjk5rfp+cwTgMpt7/Q7b571e654GHmjhP+pJTT52KhPH6a9yqpdso0ceVI N5QSwuEa/VWPp2FMfJ06TrlSs2nQp9evuDf3Bmu7xan3pWqtmyXdhvXVkvld0HBrQP cvYjO539HXG9NouXH0orndXDIx1c5FTDy0TBoiTA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729925AbeLNQOT (ORCPT ); Fri, 14 Dec 2018 11:14:19 -0500 Received: from mail.kernel.org ([198.145.29.99]:44418 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729892AbeLNQOS (ORCPT ); Fri, 14 Dec 2018 11:14:18 -0500 Received: from devnote (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1D542206E0; Fri, 14 Dec 2018 16:14:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544804057; bh=NB2kLxGcTz9is7Ml+siasg03+/uxiCXHIAVl8N494ZE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MzWT3/OdWColPzahZ6zlEtd3ByrTOS+OzgdcNeg5bfIyWyDq4DYCmnHiWHqpySoka EpYUB5/XkXy5uVzyOOoCF1NG2nSHJ5pcUHLe0j+h5XEolkY3tlmV753Yk3OGKkNzHU SWxbXXW09n+wfKlxs8eGKqBFASCEM3EAOqV+rzt4= Date: Sat, 15 Dec 2018 01:14:13 +0900 From: Masami Hiramatsu To: Tom Zanussi Cc: rostedt@goodmis.org, tglx@linutronix.de, mhiramat@kernel.org, namhyung@kernel.org, vedang.patel@intel.com, bigeasy@linutronix.de, joel@joelfernandes.org, mathieu.desnoyers@efficios.com, julia@ni.com, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org Subject: Re: [PATCH v8 09/22] tracing: Add hist trigger snapshot() action test case Message-Id: <20181215011413.a7d57f32823d316fa6af8526@kernel.org> In-Reply-To: <08e018fd4f7346435c36435d155f1aa8f9e7346d.1544483273.git.tom.zanussi@linux.intel.com> References: <08e018fd4f7346435c36435d155f1aa8f9e7346d.1544483273.git.tom.zanussi@linux.intel.com> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 10 Dec 2018 18:01:23 -0600 Tom Zanussi wrote: > From: Tom Zanussi > > Add a test case verifying the basic functionality of the > hist:snapshot() action. > Looks good to me. Acked-by: Masami Hiramatsu Thank you! > Signed-off-by: Tom Zanussi > --- > .../inter-event/trigger-snapshot-action-hist.tc | 43 ++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-snapshot-action-hist.tc > > diff --git a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-snapshot-action-hist.tc b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-snapshot-action-hist.tc > new file mode 100644 > index 000000000000..18fff69fc433 > --- /dev/null > +++ b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-snapshot-action-hist.tc > @@ -0,0 +1,43 @@ > +#!/bin/sh > +# SPDX-License-Identifier: GPL-2.0 > +# description: event trigger - test inter-event histogram trigger snapshot action > + > +fail() { #msg > + echo $1 > + exit_fail > +} > + > +if [ ! -f set_event ]; then > + echo "event tracing is not supported" > + exit_unsupported > +fi > + > +if [ ! -f snapshot ]; then > + echo "snapshot is not supported" > + exit_unsupported > +fi > + > +grep -q "onchange(var)" README || exit_unsupported # version issue > + > +grep -q "snapshot()" README || exit_unsupported # version issue > + > +echo "Test snapshot action" > + > +echo 1 > /sys/kernel/debug/tracing/events/sched/enable > + > +echo 'hist:keys=comm:newprio=prio:onchange($newprio).save(comm,prio):onchange($newprio).snapshot() if comm=="ping"' >> /sys/kernel/debug/tracing/events/sched/sched_waking/trigger > + > +ping $LOCALHOST -c 3 > +nice -n 1 ping $LOCALHOST -c 3 > + > +echo 0 > tracing_on > + > +if ! grep -q "changed:" events/sched/sched_waking/hist; then > + fail "Failed to create onchange action inter-event histogram" > +fi > + > +if ! grep -q "comm=ping" snapshot; then > + fail "Failed to create snapshot action inter-event histogram" > +fi > + > +exit 0 > -- > 2.14.1 > -- Masami Hiramatsu