From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Qian Cai <cai@lca.pw>
Cc: yamada.masahiro@socionext.com, michal.lkml@markovi.net,
mingo@kernel.org, bp@alien8.de, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org,
Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: Re: [PATCH] kbuild: error for CONFIG_ORC_UNWINDER is too much
Date: Mon, 17 Dec 2018 11:03:05 -0600 [thread overview]
Message-ID: <20181217170305.chni6e5vmev7hp4r@treble> (raw)
In-Reply-To: <20181217161728.6875-1-cai@lca.pw>
On Mon, Dec 17, 2018 at 11:17:28AM -0500, Qian Cai wrote:
> Since ifdef will be evaluated immediately in the first phrase of the
> Makefile read-in, there is no guarantee that the value for
> CONFIG_ORC_UNWINDER will be up-to-date until in the second phrase that
> this recipe is ran.
>
> include/config/%.conf: $(KCONFIG_CONFIG) include/config/auto.conf.cmd
> $(Q)$(MAKE) -f $(srctree)/Makefile syncconfig
>
> Hence, change error to warning as this is essentially a best guess. The
> original bug can be reproduced this way,
But this still doesn't fix the root of the problem, that the check
relies on a stale auto.conf.
--
Josh
next prev parent reply other threads:[~2018-12-17 17:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 3:56 include/config/auto.conf not sync up with .config Qian Cai
2018-12-17 16:17 ` [PATCH] kbuild: error for CONFIG_ORC_UNWINDER is too much Qian Cai
2018-12-17 17:03 ` Josh Poimboeuf [this message]
2018-12-17 17:13 ` Qian Cai
2018-12-17 17:49 ` Josh Poimboeuf
2018-12-17 18:11 ` Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181217170305.chni6e5vmev7hp4r@treble \
--to=jpoimboe@redhat.com \
--cc=bp@alien8.de \
--cc=cai@lca.pw \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=mingo@kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®