From: David Miller <davem@davemloft.net>
To: yuehaibing@huawei.com
Cc: Shahed.Shaikh@cavium.com, manish.chopra@cavium.com,
Dept-GELinuxNICDev@cavium.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] qlcnic: remove set but not used variables 'op, cmd_op'
Date: Tue, 18 Dec 2018 15:50:35 -0800 (PST) [thread overview]
Message-ID: <20181218.155035.232147444579151712.davem@davemloft.net> (raw)
In-Reply-To: <20181217092716.30708-1-yuehaibing@huawei.com>
From: YueHaibing <yuehaibing@huawei.com>
Date: Mon, 17 Dec 2018 17:27:16 +0800
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_pf.c:1070:5: warning:
> variable 'op' set but not used [-Wunused-but-set-variable]
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_pf.c:1342:5: warning:
> variable 'cmd_op' set but not used [-Wunused-but-set-variable]
>
> 'op' never used since introduction in commit 7cb03b2347d5 ("qlcnic:
> Support VF-PF communication channel commands.")
> 'cmd_op' not used since commit 6226204bcf20 ("qlcnic: Fix operation
> type and command type.")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied.
prev parent reply other threads:[~2018-12-18 23:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 9:27 YueHaibing
2018-12-18 23:50 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181218.155035.232147444579151712.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Dept-GELinuxNICDev@cavium.com \
--cc=Shahed.Shaikh@cavium.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manish.chopra@cavium.com \
--cc=netdev@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®