From: Andrew Morton <akpm@linux-foundation.org>
To: Ian Kent <raven@themaw.net>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
syzbot <syzbot+5399ed0832693e29f392@syzkaller.appspotmail.com>,
DmitryVyukov <dvyukov@google.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
syzkaller-bugs@googlegroups.com
Subject: Re: kernel BUG at fs/inode.c:LINE!
Date: Tue, 18 Dec 2018 13:09:58 -0800 [thread overview]
Message-ID: <20181218130958.88ac9d638c717a1ab1db9dc3@linux-foundation.org> (raw)
In-Reply-To: <66d497c00cffb3e4109ca0d5287c8277954d7132.camel@themaw.net>
On Tue, 18 Dec 2018 19:34:57 +0800 Ian Kent <raven@themaw.net> wrote:
> > See
> > https://www.ozlabs.org/~akpm/mmotm/broken-out/autofs-fix-possible-inode-leak-in-autofs_fill_super.patch
> >
> > I think this will fix it, I'll forward it to Andrew if you agree:
>
> Actually, looking at it again the above patch is plain not needed,
> dropping it and updating the patch which follows it in the series
> is what needs to be done.
>
> Andrew, what should I do to make this easiest for you to handle,
> a respost with v2 in the subject of the patch affected by dropping
> the above patch?
I dropped the patch and fixed up the fallout.
The patch wasn't true anyway. "There is no check at all for a failure
to allocate the root inode in autofs_fill_super(), handle it." In fact,
d_make_root(NULL) will just return NULL and autofs_fill_super() handles
that appropriately.
However let's note that when autofs_get_inode() or d_make_root() fail,
autofs_fill_super() will return -EINVAL. Should have been -ENOMEM, I
guess?
next prev parent reply other threads:[~2018-12-18 21:10 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 6:11 syzbot
2018-12-17 7:21 ` Al Viro
2018-12-17 10:08 ` Dmitry Vyukov
2018-12-18 10:40 ` Tetsuo Handa
2018-12-18 10:42 ` Ian Kent
2018-12-18 11:01 ` Amir Goldstein
2018-12-18 11:52 ` Ian Kent
2018-12-18 11:34 ` Ian Kent
2018-12-18 12:27 ` Dmitry Vyukov
2018-12-18 12:42 ` Ian Kent
2018-12-18 13:19 ` Dmitry Vyukov
2018-12-18 14:40 ` Ian Kent
2018-12-18 21:09 ` Andrew Morton [this message]
2018-12-19 0:05 ` Ian Kent
2018-12-18 13:51 ` Al Viro
2019-04-09 14:36 ` syzbot
2019-04-10 0:26 ` Al Viro
2019-04-10 8:27 ` Dmitry Vyukov
2019-04-10 10:35 ` Ian Kent
2019-04-10 11:40 ` Dmitry Vyukov
2019-04-10 11:57 ` Ian Kent
2019-04-10 12:02 ` Dmitry Vyukov
2019-04-10 12:03 ` Dmitry Vyukov
2019-04-10 12:07 ` Ian Kent
2019-04-10 12:11 ` Al Viro
2019-04-10 12:41 ` Dmitry Vyukov
2019-04-11 0:50 ` Ian Kent
2019-04-11 2:22 ` Al Viro
2019-04-12 11:04 ` Dmitry Vyukov
2019-04-12 19:46 ` Eric Biggers
2019-04-12 10:59 ` Dmitry Vyukov
2019-04-12 19:19 ` Al Viro
2019-04-10 12:39 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181218130958.88ac9d638c717a1ab1db9dc3@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dvyukov@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raven@themaw.net \
--cc=syzbot+5399ed0832693e29f392@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®