From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A94A0C43387 for ; Tue, 18 Dec 2018 15:12:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 79ACD21873 for ; Tue, 18 Dec 2018 15:12:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1545145955; bh=8Q4eZ8594DtSKWB2e+2mmCyVzsNilZD31iQ4WDodpxc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Pg0oCFSbrp0cPPzH2hKsuS+AVv160Mb1KN48bUHAO6BJK8mxxCJL9qQM6D9QoORJD jI/0TrCtC9N30jqX0BA17GQc3MsPEqu2Jfxmf3Qp2IE+f+4eZbnneFgb4hE1EHCfbb 8xpB94ix0gsI3fKFw1lM+d+cdJpoKmq1J/eOVsZk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726857AbeLRPMe (ORCPT ); Tue, 18 Dec 2018 10:12:34 -0500 Received: from mail.kernel.org ([198.145.29.99]:41792 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726651AbeLRPMe (ORCPT ); Tue, 18 Dec 2018 10:12:34 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E1EC121871; Tue, 18 Dec 2018 15:12:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1545145952; bh=8Q4eZ8594DtSKWB2e+2mmCyVzsNilZD31iQ4WDodpxc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QPjz+9iGGOhxNQdjSkLMzgPocoibi5BIHhy1Z84bN4AJcyiNC4g2lJz3+xC42LuKF zFtR0FA8SbiZsfzY1cRh5uWT9kDVc9GH0qT6ZJ0x1EuF1ESSnicdnIhghWfVWPsii1 uEW82Bug+Q8YAmH60lGSk41VmrGb5Tk6x2/PhSnM= Date: Tue, 18 Dec 2018 16:12:30 +0100 From: Greg Kroah-Hartman To: Sasha Levin Cc: Arnd Bergmann , stable@vger.kernel.org, Andrew Jeffery , Andy Gross , bp@alien8.de, Daniel Drake , David Brown , dou_liyang@163.com, Ingo Molnar , "James E.J. Bottomley" , Jens Frederich , Lubomir Rintel , Mark Rutland , "Martin K. Petersen" , Peter Zijlstra , Rob Clark , Rob Herring , Srinivas Kandagatla , Vincent Guittot , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, freedreno@lists.freedesktop.org, linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH 0/7] v4.19-stable randconfig fixes Message-ID: <20181218151230.GA30844@kroah.com> References: <20181214221023.3878670-1-arnd@arndb.de> <20181218002028.GX2746@sasha-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181218002028.GX2746@sasha-vm> User-Agent: Mutt/1.11.1 (2018-12-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 17, 2018 at 07:20:28PM -0500, Sasha Levin wrote: > On Fri, Dec 14, 2018 at 11:10:05PM +0100, Arnd Bergmann wrote: > > Hi Greg, > > > > I did some randconfig testing on linux-4.19 arm/arm64/x86. So far I needed > > 27 patches, most of which are also still needed in mainline Linux. I > > had submitted some before, and others were not submitted previously > > for some reason. I'll try to get those fixed in mainline and then > > make sure we get them into 4.19 as well. > > > > This series for now contains four patches that did make it into mainline: > > > > 2e6ae11dd0d1 ("slimbus: ngd: mark PM functions as __maybe_unused") > > 33f49571d750 ("staging: olpc_dcon: add a missing dependency") > > 0eeec01488da ("scsi: raid_attrs: fix unused variable warning") > > 11d4afd4ff66 ("sched/pelt: Fix warning and clean up IRQ PELT config") > > > > Feel free to either cherry-pick those from mainline or apply the > > patch from this series, whichever works best for you. > > > > The other three patches are for warnings in code that got removed in > > mainline kernels: > > > > 3e9efc3299dd ("i2c: aspeed: Handle master/slave combined irq events properly") > > 972910948fb6 ("ARM: dts: qcom: Remove Arrow SD600 eval board") > > effec874792f ("drm/msm/dpu: Remove dpu_dbg") > > > > My feeling was that it's safer to just address the warning by fixing > > the code correctly in each of these cases, but if you disagree, > > applying the mainline change should work equally well, so decide > > for yourself. > > Thanks Arnd, I took the series as is. > > We really need to discuss how -stable deals with removed code upstream. > For some cases, we should probably follow suit and remove it from > -stable as well (I'm mostly thinking dodgy code with potential security > issues). It would be nice to do that at times (like lustre and ipx), but it's good to keep that code around as maybe someone is using it? I don't know, it's a tough call... thanks, greg k-h