From: Sasha Levin <sashal@kernel.org>
To: Dexuan Cui <decui@microsoft.com>
Cc: "'gregkh@linuxfoundation.org'" <gregkh@linuxfoundation.org>,
Stephen Hemminger <stephen@networkplumber.org>,
Sasha Levin <Alexander.Levin@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
KY Srinivasan <kys@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
Michael Kelley <mikelley@microsoft.com>,
"'apw@canonical.com'" <apw@canonical.com>,
"'olaf@aepfle.de'" <olaf@aepfle.de>,
"'devel@linuxdriverproject.org'" <devel@linuxdriverproject.org>,
vkuznets <vkuznets@redhat.com>,
"'jasowang@redhat.com'" <jasowang@redhat.com>
Subject: Re: [PATCH] Drivers: hv: vmbus: Check for ring when getting debug info
Date: Tue, 18 Dec 2018 11:55:42 -0500 [thread overview]
Message-ID: <20181218165542.GA2746@sasha-vm> (raw)
In-Reply-To: <PU1P153MB016995B94393BB024F6DE7F8BFBC0@PU1P153MB0169.APCP153.PROD.OUTLOOK.COM>
On Mon, Dec 17, 2018 at 08:16:09PM +0000, Dexuan Cui wrote:
>
>fc96df16a1ce is good and can already fix the "return stack garbage" issue,
>but let's also improve hv_ringbuffer_get_debuginfo(), which would silently
>return stack garbage, if people forget to check channel->state or
>ring_info->ring_buffer, when using the function in the future.
>
>Having an error check in the function would eliminate the potential risk.
>
>Add a Fixes tag to indicate the patch depdendency.
>
>Fixes: fc96df16a1ce ("Drivers: hv: vmbus: Return -EINVAL for the sys files for unopened channels")
>Cc: stable@vger.kernel.org
>Cc: K. Y. Srinivasan <kys@microsoft.com>
>Cc: Haiyang Zhang <haiyangz@microsoft.com>
>Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
>Signed-off-by: Dexuan Cui <decui@microsoft.com>
>---
>
>*NOTE*: the patch is based on char-misc's char-misc-linus branch.
Queued up, thank you.
--
Thanks,
Sasha
prev parent reply other threads:[~2018-12-18 16:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 20:16 Dexuan Cui
2018-12-18 16:55 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181218165542.GA2746@sasha-vm \
--to=sashal@kernel.org \
--cc=Alexander.Levin@microsoft.com \
--cc=apw@canonical.com \
--cc=decui@microsoft.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=olaf@aepfle.de \
--cc=stephen@networkplumber.org \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®