mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Andrei.Stefanescu@microchip.com
Cc: lgirdwood@gmail.com, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Cristian.Birsan@microchip.com,
	Nicolas.Ferre@microchip.com
Subject: Re: [PATCH] regulator: mcp16502: code cleanup
Date: Wed, 19 Dec 2018 18:40:23 +0000	[thread overview]
Message-ID: <20181219184023.GM8130@sirena.org.uk> (raw)
In-Reply-To: <1545047086-30286-1-git-send-email-andrei.stefanescu@microchip.com>

[-- Attachment #1: Type: text/plain, Size: 709 bytes --]

On Mon, Dec 17, 2018 at 11:44:59AM +0000, Andrei.Stefanescu@microchip.com wrote:
> This patch does the following:
> - align parameter with parenthesis
> - fix compile error
> 
> If CONFIG_SUSPEND is not set the dummy pm_ops
> callbacks are named mcp16502_suspend and mcp16502_resume
> instead of mcp16502_suspend_noirq and mcp16502_resume_noirq.

Thanks for fixing this.

> 
> Excerpt from compile log (kbuild test robot):

There's no need to include the entire output from the kbuild robot in
your commit log, especially when it's much larger than either the change
or description of the change - it gets in the way of reading things as
it makes it harder to pick out relevant information.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      reply	other threads:[~2018-12-19 18:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-17 11:44 Andrei.Stefanescu
2018-12-19 18:40 ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181219184023.GM8130@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=Andrei.Stefanescu@microchip.com \
    --cc=Cristian.Birsan@microchip.com \
    --cc=Nicolas.Ferre@microchip.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®