From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAF4AC43387 for ; Thu, 20 Dec 2018 07:49:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7804521720 for ; Thu, 20 Dec 2018 07:49:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=umn.edu header.i=@umn.edu header.b="Z7aztYeT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730634AbeLTHtH (ORCPT ); Thu, 20 Dec 2018 02:49:07 -0500 Received: from mta-p7.oit.umn.edu ([134.84.196.207]:40592 "EHLO mta-p7.oit.umn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725355AbeLTHtH (ORCPT ); Thu, 20 Dec 2018 02:49:07 -0500 Received: from localhost (unknown [127.0.0.1]) by mta-p7.oit.umn.edu (Postfix) with ESMTP id D1EC7955 for ; Thu, 20 Dec 2018 07:49:05 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p7.oit.umn.edu ([127.0.0.1]) by localhost (mta-p7.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6E1gU36It21H for ; Thu, 20 Dec 2018 01:49:05 -0600 (CST) Received: from mail-it1-f197.google.com (mail-it1-f197.google.com [209.85.166.197]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p7.oit.umn.edu (Postfix) with ESMTPS id 9E8F095F for ; Thu, 20 Dec 2018 01:49:05 -0600 (CST) Received: by mail-it1-f197.google.com with SMTP id 123so1375685itv.6 for ; Wed, 19 Dec 2018 23:49:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=IW8nFsGJ120mWoROgUXJuT+1N+HNIJQhDiQ6MIXoCJs=; b=Z7aztYeTxM6JUlWHJIdUCAzs2UxECuo0vFJB/3MaBcRE8WWkJf06fs0d6r0Kfz0yQa 6kfBXpfBE0jdL/7uhzEPa/Qyjtjr/9ivCIDvMkQaw71CHkz96cgRHR5BrFtHLMDc/M4X Jdti4I4hpOREQ+fUBbD6XH5Fj9wOn0QeELvaqFdZSpOjZC09/BZnftHkklgGuwv8X59R YqQG5Z3RKB2+Oh3ZJm37HKCn3L1nRiiGwue34iMXz7dWFNxUjV3W1HxF54B5EiwFGp/Z 1jcV+3GCruiw8gPAIGWMZWANwyxJl9XXN2TXSj/lfD7LBIadKhom85e5UVPQgW1z8gMg iKrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=IW8nFsGJ120mWoROgUXJuT+1N+HNIJQhDiQ6MIXoCJs=; b=fPVYycXK8zi1NJhPXzr7ZYuLHz1T9r/fp476EBd5Gb3cKjit9BQHQthaS5XNNPOPgU gRBtxB13nbSwjLXB65MAMRwlO0Dgw+4BBQCfKAG5XcAYTem0yyuOPehXrNQfm/+N2enC VuFsxv7goMh6bjrjT86Rzo8E8lJ1lVTI8OYesHZ2XuOumMYJPBc3RBHIuQY8Z25RGKlw cRoX4gQn1apWPrhxShgIlNsJMzjJebcKmGSrPZPmXFbOfOlmgO15m7XyzorQC2LZMia5 BY4yuDLn6ADJFTrEULzj+gSO5SBUuUiM4E1mjo0CsEkttmewGimopBr+bwQzics+GjrW DdQA== X-Gm-Message-State: AA+aEWbBwcWhb/hXDjGP1APJVe9I4vk6PXMJWY7VyNSZ86GVizRnmE2F ENSwIUm53z95VjdUzDA8b8d9h5zTLt8f2pVD4SBhp/z4UZ4/jGHTU1pDQ8lGQrFAzux/EM0xsOF uOTP+a1dTF6nz+snhzfEd+aco3q96 X-Received: by 2002:a24:67c6:: with SMTP id u189mr9310952itc.106.1545292145287; Wed, 19 Dec 2018 23:49:05 -0800 (PST) X-Google-Smtp-Source: AFSGD/WkriPr96sNFq3ew2/vkmZdHuaJbGNbEKGPBKLqZMOCHj7KYwmFxHOi+pf3yfXOC5iPk51l1g== X-Received: by 2002:a24:67c6:: with SMTP id u189mr9310938itc.106.1545292145046; Wed, 19 Dec 2018 23:49:05 -0800 (PST) Received: from localhost.localdomain (host-173-230-104-24.mnmigsc.mn.minneapolis.us.clients.pavlovmedia.net. [173.230.104.24]) by smtp.gmail.com with ESMTPSA id j14sm9625305ioa.5.2018.12.19.23.49.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 19 Dec 2018 23:49:04 -0800 (PST) From: Kangjie Lu To: kjlu@umn.edu Cc: pakki001@umn.edu, Mauro Carvalho Chehab , Brad Love , Michael Ira Krufky , Luc Van Oostenryck , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: lgdt3306a: fix a missing check of return value Date: Thu, 20 Dec 2018 01:48:42 -0600 Message-Id: <20181220074844.40666-1-kjlu@umn.edu> X-Mailer: git-send-email 2.17.2 (Apple Git-113) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If lgdt3306a_read_reg() fails, the read data in "val" is incorrect, thus shouldn't be further used. The fix inserts a check for the return value of lgdt3306a_read_reg(). If it fails, goto fail. Signed-off-by: Kangjie Lu --- drivers/media/dvb-frontends/lgdt3306a.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/lgdt3306a.c b/drivers/media/dvb-frontends/lgdt3306a.c index 0e1f5daaf20c..7410f23314bc 100644 --- a/drivers/media/dvb-frontends/lgdt3306a.c +++ b/drivers/media/dvb-frontends/lgdt3306a.c @@ -1685,7 +1685,9 @@ static int lgdt3306a_read_signal_strength(struct dvb_frontend *fe, case QAM_256: case QAM_AUTO: /* need to know actual modulation to set proper SNR baseline */ - lgdt3306a_read_reg(state, 0x00a6, &val); + ret = lgdt3306a_read_reg(state, 0x00a6, &val); + if (lg_chkerr(ret)) + goto fail; if(val & 0x04) ref_snr = 2800; /* QAM-256 28dB */ else -- 2.17.2 (Apple Git-113)