From: Andrzej Hajda <a.hajda@samsung.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Andrzej Hajda <a.hajda@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org,
Javier Martinez Canillas <javierm@redhat.com>,
linux-arm-kernel@lists.infradead.org, andy.shevchenko@gmail.com,
Mark Brown <broonie@kernel.org>,
Russell King - ARM Linux <linux@armlinux.org.uk>
Subject: [PATCH v4 0/3] driver core: add probe error check helper
Date: Thu, 20 Dec 2018 11:22:44 +0100 [thread overview]
Message-ID: <20181220102247.4911-1-a.hajda@samsung.com> (raw)
In-Reply-To: <CGME20181220102258eucas1p1ca5abb0b48d1f13d9234a4a7702a13da@eucas1p1.samsung.com>
Hi Greg, Rafael,
This patchset proposes probe helper function which should simplify little bit
resource acquisition error handling, it also extend it with adding defer probe
reason to devices_deferred property:
This patchset is actually resend of the most important 1st and 2nd patch.
I have also attached patch adding probe_err_ptr - it will allow to replace
quite frequent calls:
probe_err(dev, PTR_ERR(ptr), ...)
with
probe_err_ptr(dev, ptr, ...)
I have dropped the last patch showing usage of probe_err(_ptr)? as it is
very big, should be split per subsystem, and should be applied after merge
of patches introducing probe_err(_ptr) helpers.
Just for the record - my dirty cocci script generates patch which replaces
code with probe_err* helpers with following stats (on linux_next branch):
1585 probe_err
1194 probe_err_ptr
1638 files changed, 6487 insertions(+), 9163 deletions(-).
Of course there are much more places where probe_err* can be applied, the script
tries to catch the most obvious ones.
More importantly probe_err should handle probe errors more correctly
and uniformly than it is done now.
If this patchset will be accepted I will try to send patches introducing probe_err*
per subsystem.
Regards
Andrzej
Andrzej Hajda (3):
driver core: add probe_err log helper
driver core: add deferring probe reason to devices_deferred property
driver core: add probe_err_ptr helper
drivers/base/base.h | 3 +++
drivers/base/core.c | 40 ++++++++++++++++++++++++++++++++++++++++
drivers/base/dd.c | 21 ++++++++++++++++++++-
include/linux/device.h | 5 +++++
4 files changed, 68 insertions(+), 1 deletion(-)
--
2.17.1
next parent reply other threads:[~2018-12-20 10:23 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20181220102258eucas1p1ca5abb0b48d1f13d9234a4a7702a13da@eucas1p1.samsung.com>
2018-12-20 10:22 ` Andrzej Hajda [this message]
[not found] ` <CGME20181220102259eucas1p2f748c68e01cd4e09a266da879722e218@eucas1p2.samsung.com>
2018-12-20 10:22 ` [PATCH v4 1/3] driver core: add probe_err log helper Andrzej Hajda
2018-12-20 10:35 ` Rafael J. Wysocki
2018-12-20 11:14 ` Greg Kroah-Hartman
2018-12-20 11:37 ` Andrzej Hajda
2018-12-21 22:47 ` Rob Herring
2018-12-22 7:24 ` [PATCH] driver core: platform: Add an error message to platform_get_irq*() Stephen Boyd
2018-12-22 10:33 ` Russell King - ARM Linux
2018-12-28 21:53 ` Stephen Boyd
2018-12-24 9:29 ` [PATCH v4 1/3] driver core: add probe_err log helper Andrzej Hajda
2018-12-28 21:56 ` [PATCH v2] driver core: platform: Add an error message to platform_get_irq*() Stephen Boyd
2018-12-30 10:42 ` Andy Shevchenko
2019-01-02 18:17 ` Stephen Boyd
2019-01-02 18:51 ` [PATCH v3] " Stephen Boyd
2019-01-03 9:40 ` Rafael J. Wysocki
2019-01-03 16:11 ` Stephen Boyd
2019-01-03 17:22 ` Rafael J. Wysocki
2019-01-03 17:25 ` Stephen Boyd
2019-01-03 17:38 ` Rafael J. Wysocki
2019-01-03 17:51 ` Andy Shevchenko
[not found] ` <CGME20181220102259eucas1p1884a0b68ce342239c2a43a74cc50725a@eucas1p1.samsung.com>
2018-12-20 10:22 ` [PATCH v4 2/3] driver core: add deferring probe reason to devices_deferred property Andrzej Hajda
2018-12-20 11:04 ` Rafael J. Wysocki
2018-12-20 12:27 ` Andrzej Hajda
2018-12-20 11:12 ` Greg Kroah-Hartman
2018-12-20 11:51 ` Andrzej Hajda
[not found] ` <CGME20181220102300eucas1p210735c7753688a52a73ccf026884dd11@eucas1p2.samsung.com>
2018-12-20 10:22 ` [PATCH v4 3/3] driver core: add probe_err_ptr helper Andrzej Hajda
2018-12-20 11:05 ` Rafael J. Wysocki
2018-12-20 11:14 ` Greg Kroah-Hartman
[not found] ` <CGME20181221083246eucas1p22cade911a455344d351db6060d39ddce@eucas1p2.samsung.com>
2018-12-21 8:32 ` [PATCH] PCI: pcie-rockchip: use probe_err helpers instead of open coding Andrzej Hajda
2018-12-22 5:42 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181220102247.4911-1-a.hajda@samsung.com \
--to=a.hajda@samsung.com \
--cc=andy.shevchenko@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=javierm@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®