From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29304C64E75 for ; Mon, 24 Dec 2018 22:46:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EEDF9217D6 for ; Mon, 24 Dec 2018 22:46:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725855AbeLXWqU (ORCPT ); Mon, 24 Dec 2018 17:46:20 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:37708 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725788AbeLXWqU (ORCPT ); Mon, 24 Dec 2018 17:46:20 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::cf9]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id A6B961416F334; Mon, 24 Dec 2018 14:46:19 -0800 (PST) Date: Mon, 24 Dec 2018 14:46:19 -0800 (PST) Message-Id: <20181224.144619.1708773501978498186.davem@davemloft.net> To: pakki001@umn.edu Cc: kjlu@umn.edu, ktkhai@virtuozzo.com, avagin@virtuozzo.com, tyhicks@canonical.com, willy@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net/net_namespace: Check the return value of register_pernet_subsys() From: David Miller In-Reply-To: <20181224014239.11601-1-pakki001@umn.edu> References: <20181224014239.11601-1-pakki001@umn.edu> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 24 Dec 2018 14:46:20 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Aditya Pakki Date: Sun, 23 Dec 2018 19:42:38 -0600 > In net_ns_init(), register_pernet_subsys() could fail while registering > network namespace subsystems. The fix checks the return value and > sends a panic() on failure. > > Signed-off-by: Aditya Pakki Applied.