From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 320312F30 for ; Thu, 30 Jan 2025 22:07:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738274838; cv=none; b=I1P0nznhK1lSIe7ekm9BCtnm0c3EdEV6V8kyuX4YbFjuSKZsJSXAVamhf/RtvWQsWgKdEZyhgWiR7Nfrcw+lbTuPc/NW31lHtIg1tv0bey2ogEIhks5LGywUXzpjwL8fmiCWhcsPKATLPywPMX3XLVPLezzLWNhs6oByIy/pP1U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738274838; c=relaxed/simple; bh=avmLgW8CPE51ZDwazO1xFMxHhJYKjjX6F/hB51cmtMw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=u/OZQ4IBUNwlqHI2KFSjQBV46oOA4Kx3JEpbhv2H3H8ifWzoR/mB8HMP+jmyBzW4uEMlR7Gy7DcXx6yhGUntSVlnVrL/L0NRwN/daxnsOaF40DGo+ljfaA4H88yYLZ/cs1V8ZTudxXPKdm3w4GlvjQSfzRLBEVuaF0scaQt5SNs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=cLfe2irU; arc=none smtp.client-ip=209.85.210.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="cLfe2irU" Received: by mail-ot1-f45.google.com with SMTP id 46e09a7af769-71e2bb84fe3so691391a34.1 for ; Thu, 30 Jan 2025 14:07:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1738274835; x=1738879635; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=x9PWxbMV+pc41ZeRuYe5n6UZdKx3ea5g4GHydSXEvtY=; b=cLfe2irUD0e0gv/zu4XyQPj2tRuucocCGnSxoqLLxB+e83+Z/oToOPFvTLhm9ng2yn nj1ElHU5T3cLQ1IaM7va+cR+QS0jV42RluafraIbm4xoPjdXV576+n4nZd1lTRgYUfvS WbV4/SGIgsDmLRR/YN3JRhajipRTqo4FL2RPg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738274835; x=1738879635; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=x9PWxbMV+pc41ZeRuYe5n6UZdKx3ea5g4GHydSXEvtY=; b=axZbYm97oHRZSLYd4055kDrGA6q4Kbj+afkPPE87DfYxKGpFFnqExLsYhlDZN6+R+f 4RMTHbca/FyDOyHEQo6Ph+IUiVWkh51V1LIjBdvKu0PRMkR/cdFDUZzZ0wY0bhhK3e9f o3GXflpZNPqgAbGSJoSdiDA7pOvaECtVlFmu5kDAg6ax3W1uyTcSG9DsWOfgwklbqM3u kRgKTPByQBPZqiFs8rHYOSQIeuTkwOHqWxgVeKtclVg7KzIKFVvnSpIsL9K2SP4ANYdN Q+evKAtP6kbTUsKaSowV31KGYdvTFESxYYHoJ504s/KPcmvSpr+FJ4Nx+UXdcvanPnFE Trqg== X-Forwarded-Encrypted: i=1; AJvYcCUm4UvfFOIHYI2NGFsGI7CBF60NNl/X5wdIRKZ+RATx4NneXtJy1+IP8yeQOXbRWljmcgohCKXn4sQFQDk=@vger.kernel.org X-Gm-Message-State: AOJu0YxpHuVTTChPxoBqFqyiN7NWAHL1LNLLk3xnQ50+A9Y94WitkBP8 yQlCidINEYe3nEwV0FCDi1CG+6XDHaFk46bt4jjp+4GS0YUB1t6QY7DgGSH8Qw== X-Gm-Gg: ASbGnctl79J+TXiLA3DsuzxTIGKQ1DD264IzwXxe65i+Y/pSDZQ3gLL5kSwdHLqLynY ZCXDvJ5ZSpV4+o+jxBIilt/mz7b59udlEbhErYq+cxlmmprh7/RXO7/ovTyffgsqK+SMmMg8KKb 8fo+Y+CVcnBFJsY4d3EuHLeP/7T0FHHEI5oKrI9Oxjv5Jn46YiGbGJomRy8v9yJFA1iYRKvFGkh wfc/EWzBG3LHALNnjnJxjStMljUiZzTcFuTZdze+W2RFuIyy3LvHDHPrZxguhbsEr2PFD+h2hoe QG9ExkwtLUULhDBhuBJHT7ESoRHpftZTcDs7A0TC+i9iXmUxnDGRnx8= X-Google-Smtp-Source: AGHT+IHDaNlt4S67Jjd7nYnaKKLenYdWvvL+1raluenpuKxu6pzj9agQZyPjQ99ELLdpEVnU5sZ+6A== X-Received: by 2002:a05:6830:3696:b0:71d:4488:19ed with SMTP id 46e09a7af769-7265673213cmr6436451a34.5.1738274835142; Thu, 30 Jan 2025 14:07:15 -0800 (PST) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-726618c8aefsm526589a34.67.2025.01.30.14.07.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jan 2025 14:07:14 -0800 (PST) Message-ID: <2018dc60-1cec-4575-9005-cb543c7c1856@broadcom.com> Date: Thu, 30 Jan 2025 14:07:12 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] gpio: bcm-kona: Make sure GPIO bits are unlocked when requesting IRQ To: Artur Weber , Ray Jui , Broadcom internal kernel review list , Linus Walleij , Bartosz Golaszewski , Scott Branden , Markus Mayer , Tim Kryger , Matt Porter , Markus Mayer , Christian Daudt Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht References: <20250130-kona-gpio-fixes-v1-0-dd61e0c0a9e7@gmail.com> <20250130-kona-gpio-fixes-v1-2-dd61e0c0a9e7@gmail.com> <9965d0b3-f169-45c4-9345-8588865a2ca4@broadcom.com> <4af2c24d-1c79-4119-a112-eeac1112d49c@gmail.com> Content-Language: en-US From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <4af2c24d-1c79-4119-a112-eeac1112d49c@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 1/30/25 13:46, Artur Weber wrote: > On 30.01.2025 22:35, Florian Fainelli wrote: >> On 1/30/25 09:10, Artur Weber wrote: >>> diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-kona.c >>> index >>> 77bd4ec93a231472d7bc40db9d5db12d20bb1611..eeaa921df6f072129dbdf1c73d6da2bd7c1fe716 100644 >>> --- a/drivers/gpio/gpio-bcm-kona.c >>> +++ b/drivers/gpio/gpio-bcm-kona.c >>> ... >>> @@ -87,14 +103,25 @@ static void bcm_kona_gpio_lock_gpio(struct >>> bcm_kona_gpio *kona_gpio, >>>       unsigned long flags; >>>       int bank_id = GPIO_BANK(gpio); >>>       int bit = GPIO_BIT(gpio); >>> +    struct bcm_kona_gpio_bank *bank = &kona_gpio->banks[bank_id]; >>> -    raw_spin_lock_irqsave(&kona_gpio->lock, flags); >>> +    if (bank->gpio_unlock_count[bit] == 0) { >>> +        dev_err(kona_gpio->gpio_chip.parent, >>> +            "Unbalanced locks for GPIO %u\n", gpio); >>> +        return; >> >> Don't you want to release &kona_gpio->lock here? >> > > If you're talking about the "raw_spin_lock_irqsave" call above the if > condition - note that it has been removed and was actually moved below: Oh my bad, my eye corrected that - to a + somehow. > >>> +    if (bank->gpio_unlock_count[bit] == 0) { >>> +        raw_spin_lock_irqsave(&kona_gpio->lock, flags); >>> + >>> +        val = readl(kona_gpio->reg_base + GPIO_PWD_STATUS(bank_id)); >>> +        val |= BIT(bit); >>> +        bcm_kona_gpio_write_lock_regs(kona_gpio->reg_base, bank_id, >>> val); >>> + >>> +        raw_spin_unlock_irqrestore(&kona_gpio->lock, flags); >>> +    } > > In general, the diff for this patch did not generate very well, sorry > about that. I'll see if there's anything I can do to improve that in the > future. Nah that's fine, thanks! -- Florian