From: Mark Brown <broonie@kernel.org>
To: Clark Wang <xiaoning.wang@nxp.com>
Cc: "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 8/8] spi: lpspi: add dma mode support
Date: Mon, 7 Jan 2019 15:22:07 +0000 [thread overview]
Message-ID: <20190107152207.GG9570@sirena.org.uk> (raw)
In-Reply-To: <20190107074639.6336-9-xiaoning.wang@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 858 bytes --]
On Mon, Jan 07, 2019 at 07:47:49AM +0000, Clark Wang wrote:
A couple of small nits but otherwise this looks good:
> + bytes_per_word = fsl_lpspi_bytes_per_word(transfer->bits_per_word);
> + if (bytes_per_word != 1 && bytes_per_word != 2 && bytes_per_word != 4)
> + return false;
This would be clearer written as a switch statement.
> @@ -301,12 +352,59 @@ static int fsl_lpspi_set_bitrate(struct fsl_lpspi_data *fsl_lpspi)
> writel(scldiv | (scldiv << 8) | ((scldiv >> 1) << 16),
> fsl_lpspi->base + IMX7ULP_CCR);
>
> - dev_dbg(fsl_lpspi->dev, "perclk=%d, speed=%d, prescale =%d, scldiv=%d\n",
> + dev_dbg(fsl_lpspi->dev, "perclk=%d, speed=%d, prescale=%d, scldiv=%d\n",
> perclk_rate, config.speed_hz, prescale, scldiv);
>
> return 0;
> }
>
This looks like an unrelated typo fix, should be a separate patch.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2019-01-07 15:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 7:47 [PATCH 0/8] spi: lpspi: Fix bugs and Add some functions support Clark Wang
2019-01-07 7:47 ` [PATCH 1/8] spi: lpspi: Add i.MX8 boards support for lpspi Clark Wang
2019-01-07 15:15 ` Mark Brown
2019-01-07 7:47 ` [PATCH 2/8] spi: lpspi: enable runtime pm " Clark Wang
2019-01-07 15:16 ` Mark Brown
2019-01-07 7:47 ` [PATCH 3/8] spi: lpspi: Improve the stability of lpspi data transmission Clark Wang
2019-01-07 7:47 ` [PATCH 4/8] spi: lpspi: Fix wrong transmission when don't use CONT Clark Wang
2019-01-07 18:59 ` Applied "spi: lpspi: Fix wrong transmission when don't use CONT" to the spi tree Mark Brown
2019-01-07 7:47 ` [PATCH 5/8] spi: lpspi: Fix CLK pin becomes low before one transfer Clark Wang
2019-01-07 7:47 ` [PATCH 6/8] spi: lpspi: add the error info of transfer speed setting Clark Wang
2019-01-09 12:43 ` Mark Brown
2019-01-07 7:47 ` [PATCH 7/8] spi: lpspi: Add cs-gpio support Clark Wang
2019-01-09 12:33 ` Mark Brown
2019-01-07 7:47 ` [PATCH 8/8] spi: lpspi: add dma mode support Clark Wang
2019-01-07 15:22 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190107152207.GG9570@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome