From: Greg KH <gregkh@linuxfoundation.org>
To: rkir@google.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] drivers: platform: goldfish: goldfish_sync: add a driver
Date: Tue, 8 Jan 2019 13:13:35 +0100 [thread overview]
Message-ID: <20190108121335.GA3349@kroah.com> (raw)
In-Reply-To: <20190107185039.190919-3-rkir@google.com>
On Mon, Jan 07, 2019 at 10:50:39AM -0800, rkir@google.com wrote:
> From: Roman Kiryanov <rkir@google.com>
>
> The Goldfish sync driver is designed to provide a interface
> between the underlying host's sync device and the kernel's
> fence sync framework.
>
> Signed-off-by: Roman Kiryanov <rkir@google.com>
> ---
> Changes in v2:
> - Added a missing include (mod_devicetable.h).
> - Put in one batch with goldfish_address_space.c to avoid merge comflicts.
You have a number of WARN_ON() calls in here that are not needed, please
remove.
Also, why is this driver needed at all? Why can't you use the "normal"
drm sync api interface? Why write a custom ioctl driver just for this
one kernel interface?
thanks,
greg k-h
next prev parent reply other threads:[~2019-01-08 12:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 18:50 [PATCH v2 1/3] drivers: platform: goldfish: fix the checkpatch complain in Kconfig rkir
2019-01-07 18:50 ` [PATCH v2 2/3] drivers: platform: goldfish: goldfish_address_space: add a driver rkir
2019-01-07 18:50 ` [PATCH v2 3/3] drivers: platform: goldfish: goldfish_sync: " rkir
2019-01-08 12:13 ` Greg KH [this message]
2019-01-09 0:48 ` Roman Kiryanov
2019-01-09 7:07 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190108121335.GA3349@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkir@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome