From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Yanjiang Jin <yanjiang.jin@hxt-semitech.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Sasha Levin <sashal@kernel.org>,
esc.storagedev@microsemi.com, linux-scsi@vger.kernel.org
Subject: [PATCH AUTOSEL 4.14 48/53] scsi: smartpqi: call pqi_free_interrupts() in pqi_shutdown()
Date: Tue, 8 Jan 2019 14:32:16 -0500 [thread overview]
Message-ID: <20190108193222.123316-48-sashal@kernel.org> (raw)
In-Reply-To: <20190108193222.123316-1-sashal@kernel.org>
From: Yanjiang Jin <yanjiang.jin@hxt-semitech.com>
[ Upstream commit e57b2945aa654e48f85a41e8917793c64ecb9de8 ]
We must free all irqs during shutdown, else kexec's 2nd kernel would hang
in pqi_wait_for_completion_io() as below:
Call trace:
pqi_wait_for_completion_io
pqi_submit_raid_request_synchronous.constprop.78+0x23c/0x310 [smartpqi]
pqi_configure_events+0xec/0x1f8 [smartpqi]
pqi_ctrl_init+0x814/0xca0 [smartpqi]
pqi_pci_probe+0x400/0x46c [smartpqi]
local_pci_probe+0x48/0xb0
pci_device_probe+0x14c/0x1b0
really_probe+0x218/0x3fc
driver_probe_device+0x70/0x140
__driver_attach+0x11c/0x134
bus_for_each_dev+0x70/0xc8
driver_attach+0x30/0x38
bus_add_driver+0x1f0/0x294
driver_register+0x74/0x12c
__pci_register_driver+0x64/0x70
pqi_init+0xd0/0x10000 [smartpqi]
do_one_initcall+0x60/0x1d8
do_init_module+0x64/0x1f8
load_module+0x10ec/0x1350
__se_sys_finit_module+0xd4/0x100
__arm64_sys_finit_module+0x28/0x34
el0_svc_handler+0x104/0x160
el0_svc+0x8/0xc
This happens only in the following combinations:
1. smartpqi is built as module, not built-in;
2. We have a disk connected to smartpqi card;
3. Both kexec's 1st and 2nd kernels use this disk as Rootfs' mount point.
Signed-off-by: Yanjiang Jin <yanjiang.jin@hxt-semitech.com>
Acked-by: Don Brace <don.brace@microsemi.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/scsi/smartpqi/smartpqi_init.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c
index b662f58203ac..bc15999f1c7c 100644
--- a/drivers/scsi/smartpqi/smartpqi_init.c
+++ b/drivers/scsi/smartpqi/smartpqi_init.c
@@ -6703,6 +6703,7 @@ static void pqi_shutdown(struct pci_dev *pci_dev)
* storage.
*/
rc = pqi_flush_cache(ctrl_info, SHUTDOWN);
+ pqi_free_interrupts(ctrl_info);
pqi_reset(ctrl_info);
if (rc == 0)
return;
--
2.19.1
next prev parent reply other threads:[~2019-01-08 19:33 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 19:31 [PATCH AUTOSEL 4.14 01/53] gpio: pl061: Move irq_chip definition inside struct pl061 Sasha Levin
2019-01-08 19:31 ` [PATCH AUTOSEL 4.14 02/53] platform/x86: asus-wmi: Tell the EC the OS will handle the display off hotkey Sasha Levin
2019-01-08 19:31 ` [PATCH AUTOSEL 4.14 03/53] e1000e: allow non-monotonic SYSTIM readings Sasha Levin
2019-01-08 19:31 ` [PATCH AUTOSEL 4.14 04/53] writeback: don't decrement wb->refcnt if !wb->bdi Sasha Levin
2019-01-08 19:31 ` [PATCH AUTOSEL 4.14 05/53] serial: set suppress_bind_attrs flag only if builtin Sasha Levin
2019-01-08 19:31 ` [PATCH AUTOSEL 4.14 06/53] ALSA: oxfw: add support for APOGEE duet FireWire Sasha Levin
2019-01-08 19:31 ` [PATCH AUTOSEL 4.14 07/53] x86/mce: Fix -Wmissing-prototypes warnings Sasha Levin
2019-01-08 19:31 ` [PATCH AUTOSEL 4.14 08/53] MIPS: SiByte: Enable swiotlb for SWARM, LittleSur and BigSur Sasha Levin
2019-01-08 19:31 ` [PATCH AUTOSEL 4.14 09/53] arm64: perf: set suppress_bind_attrs flag to true Sasha Levin
2019-01-08 19:31 ` [PATCH AUTOSEL 4.14 10/53] USB: serial: ftdi_sio: use rounding when calculating baud rate divisors Sasha Levin
2019-01-08 19:31 ` [PATCH AUTOSEL 4.14 11/53] usb: gadget: udc: renesas_usb3: add a safety connection way for forced_b_device Sasha Levin
2019-01-08 19:31 ` [PATCH AUTOSEL 4.14 12/53] selinux: always allow mounting submounts Sasha Levin
2019-01-08 19:31 ` [PATCH AUTOSEL 4.14 13/53] drm/amdgpu: Correct get_crtc_scanoutpos behavior when vpos >= vtotal Sasha Levin
2019-01-08 19:31 ` [PATCH AUTOSEL 4.14 14/53] rxe: IB_WR_REG_MR does not capture MR's iova field Sasha Levin
2019-01-08 19:31 ` [PATCH AUTOSEL 4.14 15/53] jffs2: Fix use of uninitialized delayed_work, lockdep breakage Sasha Levin
2019-01-08 19:31 ` [PATCH AUTOSEL 4.14 16/53] clk: imx: make mux parent strings const Sasha Levin
2019-01-08 19:31 ` [PATCH AUTOSEL 4.14 17/53] pstore/ram: Do not treat empty buffers as valid Sasha Levin
2019-01-08 19:31 ` [PATCH AUTOSEL 4.14 18/53] powerpc/xmon: Fix invocation inside lock region Sasha Levin
2019-01-08 19:31 ` [PATCH AUTOSEL 4.14 19/53] powerpc/pseries/cpuidle: Fix preempt warning Sasha Levin
2019-01-08 19:31 ` [PATCH AUTOSEL 4.14 20/53] arm64: relocatable: fix inconsistencies in linker script and options Sasha Levin
2019-01-08 19:31 ` [PATCH AUTOSEL 4.14 21/53] media: firewire: Fix app_info parameter type in avc_ca{,_app}_info Sasha Levin
2019-01-08 19:31 ` [PATCH AUTOSEL 4.14 22/53] IB/hfi1: Incorrect sizing of sge for PIO will OOPs Sasha Levin
2019-01-08 19:31 ` [PATCH AUTOSEL 4.14 23/53] media: venus: core: Set dma maximum segment size Sasha Levin
2019-01-08 19:31 ` [PATCH AUTOSEL 4.14 24/53] net: call sk_dst_reset when set SO_DONTROUTE Sasha Levin
2019-01-08 19:31 ` [PATCH AUTOSEL 4.14 25/53] scsi: target: use consistent left-aligned ASCII INQUIRY data Sasha Levin
2019-01-08 19:31 ` [PATCH AUTOSEL 4.14 26/53] selftests: do not macro-expand failed assertion expressions Sasha Levin
2019-01-08 19:31 ` [PATCH AUTOSEL 4.14 27/53] clk: imx6q: reset exclusive gates on init Sasha Levin
2019-01-08 19:31 ` [PATCH AUTOSEL 4.14 28/53] arm64: Fix minor issues with the dcache_by_line_op macro Sasha Levin
2019-01-08 19:31 ` [PATCH AUTOSEL 4.14 29/53] kconfig: fix file name and line number of warn_ignored_character() Sasha Levin
2019-01-08 19:31 ` [PATCH AUTOSEL 4.14 30/53] kconfig: fix memory leak when EOF is encountered in quotation Sasha Levin
2019-01-08 19:31 ` [PATCH AUTOSEL 4.14 31/53] mmc: atmel-mci: do not assume idle after atmci_request_end Sasha Levin
2019-01-08 19:32 ` [PATCH AUTOSEL 4.14 32/53] btrfs: improve error handling of btrfs_add_link Sasha Levin
2019-01-08 19:32 ` [PATCH AUTOSEL 4.14 33/53] tty/serial: do not free trasnmit buffer page under port lock Sasha Levin
2019-01-08 19:32 ` [PATCH AUTOSEL 4.14 34/53] perf intel-pt: Fix error with config term "pt=0" Sasha Levin
2019-01-08 19:32 ` [PATCH AUTOSEL 4.14 35/53] perf svghelper: Fix unchecked usage of strncpy() Sasha Levin
2019-01-08 19:32 ` [PATCH AUTOSEL 4.14 36/53] perf parse-events: " Sasha Levin
2019-01-08 19:32 ` [PATCH AUTOSEL 4.14 37/53] netfilter: ipt_CLUSTERIP: check MAC address when duplicate config is set Sasha Levin
2019-01-08 19:32 ` [PATCH AUTOSEL 4.14 38/53] dm crypt: use u64 instead of sector_t to store iv_offset Sasha Levin
2019-01-08 19:32 ` [PATCH AUTOSEL 4.14 39/53] dm kcopyd: Fix bug causing workqueue stalls Sasha Levin
2019-01-08 19:32 ` [PATCH AUTOSEL 4.14 40/53] tools lib subcmd: Don't add the kernel sources to the include path Sasha Levin
2019-01-08 19:32 ` [PATCH AUTOSEL 4.14 41/53] dm snapshot: Fix excessive memory usage and workqueue stalls Sasha Levin
2019-01-08 19:32 ` [PATCH AUTOSEL 4.14 42/53] quota: Lock s_umount in exclusive mode for Q_XQUOTA{ON,OFF} quotactls Sasha Levin
2019-01-08 19:32 ` [PATCH AUTOSEL 4.14 43/53] clocksource/drivers/integrator-ap: Add missing of_node_put() Sasha Levin
2019-01-08 19:32 ` [PATCH AUTOSEL 4.14 44/53] ALSA: bebob: fix model-id of unit for Apogee Ensemble Sasha Levin
2019-01-08 19:32 ` [PATCH AUTOSEL 4.14 45/53] sysfs: Disable lockdep for driver bind/unbind files Sasha Levin
2019-01-08 19:32 ` [PATCH AUTOSEL 4.14 46/53] IB/usnic: Fix potential deadlock Sasha Levin
2019-01-08 19:32 ` [PATCH AUTOSEL 4.14 47/53] scsi: smartpqi: correct lun reset issues Sasha Levin
2019-01-08 19:32 ` Sasha Levin [this message]
2019-01-08 19:32 ` [PATCH AUTOSEL 4.14 49/53] scsi: megaraid: fix out-of-bound array accesses Sasha Levin
2019-01-08 19:32 ` [PATCH AUTOSEL 4.14 50/53] ocfs2: fix panic due to unrecovered local alloc Sasha Levin
2019-01-08 19:32 ` [PATCH AUTOSEL 4.14 51/53] mm/page-writeback.c: don't break integrity writeback on ->writepage() error Sasha Levin
2019-01-08 19:32 ` [PATCH AUTOSEL 4.14 52/53] mm/swap: use nr_node_ids for avail_lists in swap_info_struct Sasha Levin
2019-01-08 19:32 ` [PATCH AUTOSEL 4.14 53/53] mm, proc: be more verbose about unstable VMA flags in /proc/<pid>/smaps Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190108193222.123316-48-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=esc.storagedev@microsemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stable@vger.kernel.org \
--cc=yanjiang.jin@hxt-semitech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome