mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Chuck Lever <chuck.lever@oracle.com>,
	Jason Gunthorpe <jgg@mellanox.com>,
	Sasha Levin <sashal@kernel.org>,
	linux-rdma@vger.kernel.org
Subject: [PATCH AUTOSEL 4.9 11/36] rxe: IB_WR_REG_MR does not capture MR's iova field
Date: Tue,  8 Jan 2019 14:33:23 -0500	[thread overview]
Message-ID: <20190108193348.123880-11-sashal@kernel.org> (raw)
In-Reply-To: <20190108193348.123880-1-sashal@kernel.org>

From: Chuck Lever <chuck.lever@oracle.com>

[ Upstream commit b024dd0eba6e6d568f69d63c5e3153aba94c23e3 ]

FRWR memory registration is done with a series of calls and WRs.
1. ULP invokes ib_dma_map_sg()
2. ULP invokes ib_map_mr_sg()
3. ULP posts an IB_WR_REG_MR on the Send queue

Step 2 generates an iova. It is permissible for ULPs to change this
iova (with certain restrictions) between steps 2 and 3.

rxe_map_mr_sg captures the MR's iova but later when rxe processes the
REG_MR WR, it ignores the MR's iova field. If a ULP alters the MR's iova
after step 2 but before step 3, rxe never captures that change.

When the remote sends an RDMA Read targeting that MR, rxe looks up the
R_key, but the altered iova does not match the iova stored in the MR,
causing the RDMA Read request to fail.

Reported-by: Anna Schumaker <schumaker.anna@gmail.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/infiniband/sw/rxe/rxe_req.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/infiniband/sw/rxe/rxe_req.c b/drivers/infiniband/sw/rxe/rxe_req.c
index 47219ebd8ff2..0f9fe2ca2a91 100644
--- a/drivers/infiniband/sw/rxe/rxe_req.c
+++ b/drivers/infiniband/sw/rxe/rxe_req.c
@@ -643,6 +643,7 @@ int rxe_requester(void *arg)
 			rmr->access = wqe->wr.wr.reg.access;
 			rmr->lkey = wqe->wr.wr.reg.key;
 			rmr->rkey = wqe->wr.wr.reg.key;
+			rmr->iova = wqe->wr.wr.reg.mr->iova;
 			wqe->state = wqe_state_done;
 			wqe->status = IB_WC_SUCCESS;
 		} else {
-- 
2.19.1


  parent reply	other threads:[~2019-01-08 19:34 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-08 19:33 [PATCH AUTOSEL 4.9 01/36] platform/x86: asus-wmi: Tell the EC the OS will handle the display off hotkey Sasha Levin
2019-01-08 19:33 ` [PATCH AUTOSEL 4.9 02/36] e1000e: allow non-monotonic SYSTIM readings Sasha Levin
2019-01-08 19:33 ` [PATCH AUTOSEL 4.9 03/36] writeback: don't decrement wb->refcnt if !wb->bdi Sasha Levin
2019-01-08 19:33 ` [PATCH AUTOSEL 4.9 04/36] serial: set suppress_bind_attrs flag only if builtin Sasha Levin
2019-01-08 19:33 ` [PATCH AUTOSEL 4.9 05/36] ALSA: oxfw: add support for APOGEE duet FireWire Sasha Levin
2019-01-08 19:33 ` [PATCH AUTOSEL 4.9 06/36] MIPS: SiByte: Enable swiotlb for SWARM, LittleSur and BigSur Sasha Levin
2019-01-08 19:33 ` [PATCH AUTOSEL 4.9 07/36] arm64: perf: set suppress_bind_attrs flag to true Sasha Levin
2019-01-08 19:33 ` [PATCH AUTOSEL 4.9 08/36] USB: serial: ftdi_sio: use rounding when calculating baud rate divisors Sasha Levin
2019-01-08 19:33 ` [PATCH AUTOSEL 4.9 09/36] selinux: always allow mounting submounts Sasha Levin
2019-01-08 19:33 ` [PATCH AUTOSEL 4.9 10/36] drm/amdgpu: Correct get_crtc_scanoutpos behavior when vpos >= vtotal Sasha Levin
2019-01-08 19:33 ` Sasha Levin [this message]
2019-01-08 19:33 ` [PATCH AUTOSEL 4.9 12/36] jffs2: Fix use of uninitialized delayed_work, lockdep breakage Sasha Levin
2019-01-08 19:33 ` [PATCH AUTOSEL 4.9 13/36] pstore/ram: Do not treat empty buffers as valid Sasha Levin
2019-01-08 19:33 ` [PATCH AUTOSEL 4.9 14/36] powerpc/xmon: Fix invocation inside lock region Sasha Levin
2019-01-08 19:33 ` [PATCH AUTOSEL 4.9 15/36] powerpc/pseries/cpuidle: Fix preempt warning Sasha Levin
2019-01-08 19:33 ` [PATCH AUTOSEL 4.9 16/36] media: firewire: Fix app_info parameter type in avc_ca{,_app}_info Sasha Levin
2019-01-08 19:33 ` [PATCH AUTOSEL 4.9 17/36] net: call sk_dst_reset when set SO_DONTROUTE Sasha Levin
2019-01-08 19:33 ` [PATCH AUTOSEL 4.9 18/36] scsi: target: use consistent left-aligned ASCII INQUIRY data Sasha Levin
2019-01-08 19:33 ` [PATCH AUTOSEL 4.9 19/36] clk: imx6q: reset exclusive gates on init Sasha Levin
2019-01-08 19:33 ` [PATCH AUTOSEL 4.9 20/36] kconfig: fix file name and line number of warn_ignored_character() Sasha Levin
2019-01-08 19:33 ` [PATCH AUTOSEL 4.9 21/36] kconfig: fix memory leak when EOF is encountered in quotation Sasha Levin
2019-01-08 19:33 ` [PATCH AUTOSEL 4.9 22/36] mmc: atmel-mci: do not assume idle after atmci_request_end Sasha Levin
2019-01-08 19:33 ` [PATCH AUTOSEL 4.9 23/36] tty/serial: do not free trasnmit buffer page under port lock Sasha Levin
2019-01-08 19:33 ` [PATCH AUTOSEL 4.9 24/36] perf intel-pt: Fix error with config term "pt=0" Sasha Levin
2019-01-08 19:33 ` [PATCH AUTOSEL 4.9 25/36] perf svghelper: Fix unchecked usage of strncpy() Sasha Levin
2019-01-08 19:33 ` [PATCH AUTOSEL 4.9 26/36] perf parse-events: " Sasha Levin
2019-01-08 19:33 ` [PATCH AUTOSEL 4.9 27/36] dm kcopyd: Fix bug causing workqueue stalls Sasha Levin
2019-01-08 19:33 ` [PATCH AUTOSEL 4.9 28/36] tools lib subcmd: Don't add the kernel sources to the include path Sasha Levin
2019-01-08 19:33 ` [PATCH AUTOSEL 4.9 29/36] dm snapshot: Fix excessive memory usage and workqueue stalls Sasha Levin
2019-01-08 19:33 ` [PATCH AUTOSEL 4.9 30/36] ALSA: bebob: fix model-id of unit for Apogee Ensemble Sasha Levin
2019-01-08 19:33 ` [PATCH AUTOSEL 4.9 31/36] sysfs: Disable lockdep for driver bind/unbind files Sasha Levin
2019-01-08 19:33 ` [PATCH AUTOSEL 4.9 32/36] scsi: smartpqi: correct lun reset issues Sasha Levin
2019-01-08 19:33 ` [PATCH AUTOSEL 4.9 33/36] scsi: megaraid: fix out-of-bound array accesses Sasha Levin
2019-01-08 19:33 ` [PATCH AUTOSEL 4.9 34/36] ocfs2: fix panic due to unrecovered local alloc Sasha Levin
2019-01-08 19:33 ` [PATCH AUTOSEL 4.9 35/36] mm/page-writeback.c: don't break integrity writeback on ->writepage() error Sasha Levin
2019-01-08 19:33 ` [PATCH AUTOSEL 4.9 36/36] mm, proc: be more verbose about unstable VMA flags in /proc/<pid>/smaps Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190108193348.123880-11-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=jgg@mellanox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome