From: Nicolas Pitre <nicolas.pitre@linaro.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Dave Mielke <Dave@mielke.cc>, linux-kernel@vger.kernel.org
Subject: [PATCH 6/6] vcs: fasync(): make it consistent with poll()
Date: Tue, 8 Jan 2019 22:55:04 -0500 [thread overview]
Message-ID: <20190109035504.8413-7-nicolas.pitre@linaro.org> (raw)
In-Reply-To: <20190109035504.8413-1-nicolas.pitre@linaro.org>
We use POLLPRI not POLLIN to wait for data with poll() as there is
never any incoming data stream per se. Let's use the same semantic
with fasync() for consistency, including the fact that a vt may go away.
No known user space ever relied on the SIGIO reason so far, let alone
FASYNC, so the risk of breakage is pretty much nonexistent.
Signed-off-by: Nicolas Pitre <nico@linaro.org>
---
drivers/tty/vt/vc_screen.c | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/drivers/tty/vt/vc_screen.c b/drivers/tty/vt/vc_screen.c
index 1bbe2a30cd..1d887113ff 100644
--- a/drivers/tty/vt/vc_screen.c
+++ b/drivers/tty/vt/vc_screen.c
@@ -93,9 +93,18 @@ vcs_notifier(struct notifier_block *nb, unsigned long code, void *_param)
struct vcs_poll_data *poll =
container_of(nb, struct vcs_poll_data, notifier);
int currcons = poll->cons_num;
-
- if (code != VT_UPDATE && code != VT_DEALLOCATE)
+ int fa_band;
+
+ switch (code) {
+ case VT_UPDATE:
+ fa_band = POLL_PRI;
+ break;
+ case VT_DEALLOCATE:
+ fa_band = POLL_HUP;
+ break;
+ default:
return NOTIFY_DONE;
+ }
if (currcons == 0)
currcons = fg_console;
@@ -106,7 +115,7 @@ vcs_notifier(struct notifier_block *nb, unsigned long code, void *_param)
poll->event = code;
wake_up_interruptible(&poll->waitq);
- kill_fasync(&poll->fasync, SIGIO, POLL_IN);
+ kill_fasync(&poll->fasync, SIGIO, fa_band);
return NOTIFY_OK;
}
--
2.20.1
next prev parent reply other threads:[~2019-01-09 4:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 3:54 [PATCH 0/6] assorted console/vt/vcs fixes Nicolas Pitre
2019-01-09 3:54 ` [PATCH 1/6] vt: make vt_console_print() compatible with the unicode screen buffer Nicolas Pitre
2019-01-09 3:55 ` [PATCH 2/6] vt: always call notifier with the console lock held Nicolas Pitre
2019-01-09 3:55 ` [PATCH 3/6] vt: invoke notifier on screen size change Nicolas Pitre
2019-01-09 3:55 ` [PATCH 4/6] vcsa: clamp header values when they don't fit Nicolas Pitre
2019-01-09 3:55 ` [PATCH 5/6] vcs: poll(): cope with a deallocated vt Nicolas Pitre
2019-01-10 0:13 ` Nicolas Pitre
2019-01-09 3:55 ` Nicolas Pitre [this message]
2019-01-18 12:49 ` [PATCH 0/6] assorted console/vt/vcs fixes Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190109035504.8413-7-nicolas.pitre@linaro.org \
--to=nicolas.pitre@linaro.org \
--cc=Dave@mielke.cc \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®