From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43E28C43387 for ; Wed, 9 Jan 2019 11:07:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1709C20449 for ; Wed, 9 Jan 2019 11:07:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730691AbfAILH4 (ORCPT ); Wed, 9 Jan 2019 06:07:56 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:41338 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730616AbfAILH4 (ORCPT ); Wed, 9 Jan 2019 06:07:56 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 53CAFA78; Wed, 9 Jan 2019 03:07:55 -0800 (PST) Received: from queper01-lin (queper01-lin.cambridge.arm.com [10.1.195.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CAD373F70D; Wed, 9 Jan 2019 03:07:53 -0800 (PST) Date: Wed, 9 Jan 2019 11:07:52 +0000 From: Quentin Perret To: "Rafael J. Wysocki" Cc: Viresh Kumar , sudeep.holla@arm.com, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dietmar.eggemann@arm.com, qais.yousef@arm.com Subject: Re: [PATCH] cpufreq: scmi: Fix frequency invariance in slow path Message-ID: <20190109110749.6ry4fxujkmrpcl7y@queper01-lin> References: <20190109104236.6532-1-quentin.perret@arm.com> <5435767.4D6MIGYIVi@aspire.rjw.lan> <20190109105902.ytnolu2gldhana4c@queper01-lin> <1798133.Rn2TxhOzAS@aspire.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1798133.Rn2TxhOzAS@aspire.rjw.lan> User-Agent: NeoMutt/20171215 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 09 Jan 2019 at 12:03:49 (+0100), Rafael J. Wysocki wrote: > On Wednesday, January 9, 2019 11:59:05 AM CET Quentin Perret wrote: > > On Wednesday 09 Jan 2019 at 11:56:06 (+0100), Rafael J. Wysocki wrote: > > > On Wednesday, January 9, 2019 11:45:11 AM CET Viresh Kumar wrote: > > > > On 09-01-19, 10:42, Quentin Perret wrote: > > > > > The scmi-cpufreq driver calls the arch_set_freq_scale() callback on > > > > > frequency changes to provide scale-invariant load-tracking signals to > > > > > the scheduler. However, in the slow path, it does so while specifying > > > > > the current and max frequencies in different units, hence resulting in a > > > > > broken freq_scale factor. > > > > > > > > > > Fix this by passing all frequencies in KHz, as stored in the CPUFreq > > > > > frequency table. > > > > > > > > > > Fixes: 99d6bdf33877 ("cpufreq: add support for CPU DVFS based on SCMI > > > > > message protocol") > > > > > Signed-off-by: Quentin Perret > > > > > --- > > > > > drivers/cpufreq/scmi-cpufreq.c | 4 ++-- > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > > diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c > > > > > index 50b1551ba894..3f0693439486 100644 > > > > > --- a/drivers/cpufreq/scmi-cpufreq.c > > > > > +++ b/drivers/cpufreq/scmi-cpufreq.c > > > > > @@ -52,9 +52,9 @@ scmi_cpufreq_set_target(struct cpufreq_policy *policy, unsigned int index) > > > > > int ret; > > > > > struct scmi_data *priv = policy->driver_data; > > > > > struct scmi_perf_ops *perf_ops = handle->perf_ops; > > > > > - u64 freq = policy->freq_table[index].frequency * 1000; > > > > > + u64 freq = policy->freq_table[index].frequency; > > > > > > > > > > - ret = perf_ops->freq_set(handle, priv->domain_id, freq, false); > > > > > + ret = perf_ops->freq_set(handle, priv->domain_id, freq * 1000, false); > > > > > if (!ret) > > > > > arch_set_freq_scale(policy->related_cpus, freq, > > > > > policy->cpuinfo.max_freq); > > > > > > > > Acked-by: Viresh Kumar > > > > > > This would be stable-candidate I guess? > > > > I think so yes. I was hoping the 'Fixes:' tag would be enough ? > > It doesn't cause -stable to pick up commits automatically if that's > what you're asking about. > > > Or do I still need to CC stable too ? > > No, you don't need to (and should not) CC -stable yourself. > > You can, however, add a Cc: tag to the patch which helps > maintainers a bit. OK, will do from now on. Thanks ! Quentin