From: Andrew Morton <akpm@linux-foundation.org>
To: peter enderborg <peter.enderborg@sony.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Olof Johansson <olof@lixom.net>,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
Huang Shijie <sjhuang@iluvatar.ai>,
Alexey Skidanov <alexey.skidanov@intel.com>
Subject: Re: [PATCH] lib/genalloc.c: include vmalloc.h
Date: Thu, 10 Jan 2019 15:51:08 -0800 [thread overview]
Message-ID: <20190110155108.a9a54ff592d00c0586691717@linux-foundation.org> (raw)
In-Reply-To: <1b876fba-28dc-ba7d-41f3-04580bc0c4b6@sony.com>
On Thu, 10 Jan 2019 14:13:44 +0100 peter enderborg <peter.enderborg@sony.com> wrote:
> On 1/7/19 11:56 PM, Andrew Morton wrote:
> > On Sat, 5 Jan 2019 13:35:33 -0800 Linus Torvalds <torvalds@linux-foundation.org> wrote:
> >
> >> On Sat, Jan 5, 2019 at 1:21 PM Olof Johansson <olof@lixom.net> wrote:
> >>> Fixes build break on most ARM/ARM64 defconfigs:
> >> Interesting.
> >>
> >> Andrew, I thought ARM was one of the platforms that your tree compiled
> >> against? Or was some other change just hiding this?
> >>
> > I've become a bit lazy with the cross-compiling because linux-next's
> > build coverage is pretty broad. But Stephen's holiday interrupted
> > things and this one fell in that window.
> >
> Is it now OK to use vmalloc in fast path's on all platforms?
I'd say not. It is slower than kmalloc and these changes did nothing
to speed it up.
That being said, vmalloc is for "large" memory allocations and large
amounts of memory take large amount of time to utilize, so unless the
code is allocating then freeing memory without using it (don't do that)
then vmalloc() can never be a "fast path" thing?
prev parent reply other threads:[~2019-01-10 23:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-05 21:21 Olof Johansson
2019-01-05 21:35 ` Linus Torvalds
2019-01-05 21:44 ` Olof Johansson
2019-01-07 22:56 ` Andrew Morton
2019-01-10 13:13 ` peter enderborg
2019-01-10 23:51 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190110155108.a9a54ff592d00c0586691717@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alexey.skidanov@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=peter.enderborg@sony.com \
--cc=sjhuang@iluvatar.ai \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®