From: Brian Masney <masneyb@onstation.org>
To: linus.walleij@linaro.org, sboyd@kernel.org,
bjorn.andersson@linaro.org, andy.gross@linaro.org
Cc: marc.zyngier@arm.com, shawnguo@kernel.org, dianders@chromium.org,
linux-gpio@vger.kernel.org, nicolas.dechesne@linaro.org,
niklas.cassel@linaro.org, david.brown@linaro.org,
robh+dt@kernel.org, mark.rutland@arm.com,
thierry.reding@gmail.com, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: [PATCH v4 14/14] spmi: pmic-arb: revert "disassociate old virq if hwirq mapping already exists"
Date: Sun, 13 Jan 2019 10:47:16 -0500 [thread overview]
Message-ID: <20190113154716.5145-15-masneyb@onstation.org> (raw)
In-Reply-To: <20190113154716.5145-1-masneyb@onstation.org>
Now that spmi-gpio is a proper hierarchical IRQ chip, and all in-tree
users of device tree have been updated, we can now drop the hack that
was introduced to disassociate the old Linux virq if a hwirq mapping
already exists. That patch was introduced to not break git bisect for
any existing boards.
Driver was tested using gpio-keys and iadc/vadc on the LG Nexus 5
(hammerhead) phone.
Signed-off-by: Brian Masney <masneyb@onstation.org>
---
This is a new patch introduced in V4.
drivers/spmi/spmi-pmic-arb.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
index b7cfee831417..356bc3f66e22 100644
--- a/drivers/spmi/spmi-pmic-arb.c
+++ b/drivers/spmi/spmi-pmic-arb.c
@@ -744,14 +744,8 @@ static void qpnpint_irq_domain_map(struct spmi_pmic_arb *pmic_arb,
struct irq_domain *domain, unsigned int virq,
irq_hw_number_t hwirq)
{
- unsigned int old_virq;
-
dev_dbg(&pmic_arb->spmic->dev, "virq = %u, hwirq = %lu\n", virq, hwirq);
- old_virq = irq_find_mapping(domain, hwirq);
- if (old_virq)
- irq_domain_disassociate(domain, old_virq);
-
irq_domain_set_info(domain, virq, hwirq, &pmic_arb_irqchip, pmic_arb,
handle_level_irq, NULL, NULL);
}
--
2.17.2
next prev parent reply other threads:[~2019-01-13 15:48 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-13 15:47 [PATCH v4 00/14] qcom: spmi: add support for hierarchical IRQ chip Brian Masney
2019-01-13 15:47 ` [PATCH v4 01/14] dt-bindings: pinctrl: qcom-pmic-gpio: add qcom,pmi8998-gpio binding Brian Masney
2019-01-14 23:42 ` Stephen Boyd
2019-01-15 0:28 ` Bjorn Andersson
2019-01-15 20:07 ` Rob Herring
2019-01-13 15:47 ` [PATCH v4 02/14] pinctrl: qcom: spmi-gpio: add support for three new variants Brian Masney
2019-01-14 23:43 ` Stephen Boyd
2019-01-15 0:28 ` Bjorn Andersson
2019-01-13 15:47 ` [PATCH v4 03/14] pinctrl: qcom: spmi-gpio: hardcode IRQ counts Brian Masney
2019-01-14 23:43 ` Stephen Boyd
2019-01-15 0:34 ` Bjorn Andersson
2019-01-15 1:14 ` Brian Masney
2019-01-15 1:24 ` Brian Masney
2019-01-13 15:47 ` [PATCH v4 04/14] spmi: pmic-arb: convert to v2 irq interfaces to support hierarchical IRQ chips Brian Masney
2019-01-13 15:47 ` [PATCH v4 05/14] gpio: add irq domain activate/deactivate functions Brian Masney
2019-01-13 15:47 ` [PATCH v4 06/14] spmi: pmic-arb: disassociate old virq if hwirq mapping already exists Brian Masney
2019-01-14 23:50 ` Stephen Boyd
2019-01-15 0:42 ` Bjorn Andersson
2019-01-13 15:47 ` [PATCH v4 07/14] qcom: spmi-gpio: add support for hierarchical IRQ chip Brian Masney
2019-01-13 15:47 ` [PATCH v4 08/14] ARM: dts: qcom: pm8941: add interrupt controller properties Brian Masney
2019-01-15 0:42 ` Bjorn Andersson
2019-01-13 15:47 ` [PATCH v4 09/14] ARM: dts: qcom: pma8084: " Brian Masney
2019-01-14 23:44 ` Stephen Boyd
2019-01-15 0:42 ` Bjorn Andersson
2019-01-13 15:47 ` [PATCH v4 10/14] arm64: dts: qcom: pm8005: " Brian Masney
2019-01-14 23:44 ` Stephen Boyd
2019-01-15 0:43 ` Bjorn Andersson
2019-01-13 15:47 ` [PATCH v4 11/14] arm64: dts: qcom: pm8998: " Brian Masney
2019-01-14 23:44 ` Stephen Boyd
2019-01-15 0:43 ` Bjorn Andersson
2019-01-13 15:47 ` [PATCH v4 12/14] arm64: dts: qcom: pmi8994: " Brian Masney
2019-01-14 23:43 ` Stephen Boyd
2019-01-15 0:43 ` Bjorn Andersson
2019-01-13 15:47 ` [PATCH v4 13/14] arm64: dts: qcom: pmi8998: " Brian Masney
2019-01-14 23:43 ` Stephen Boyd
2019-01-15 0:43 ` Bjorn Andersson
2019-01-13 15:47 ` Brian Masney [this message]
2019-01-14 8:43 ` [PATCH v4 00/14] qcom: spmi: add support for hierarchical IRQ chip Linus Walleij
2019-01-14 8:45 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190113154716.5145-15-masneyb@onstation.org \
--to=masneyb@onstation.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=nicolas.dechesne@linaro.org \
--cc=niklas.cassel@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®