From: Jan Kara <jack@suse.cz>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Andreas Dilger <adilger@dilger.ca>, Jan Kara <jack@suse.com>,
Theodore Tso <tytso@mit.edu>,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Preserving a rev 0.0 ext2 filesystem
Date: Mon, 14 Jan 2019 13:50:17 +0100 [thread overview]
Message-ID: <20190114125017.GI13316@quack2.suse.cz> (raw)
In-Reply-To: <CAMuHMdWt+6Aeius=PFr9vQgF7LGde78f9nyai4m1P8QL+oqY0A@mail.gmail.com>
On Mon 14-01-19 11:23:30, Geert Uytterhoeven wrote:
> Thanks, since ext2 also has the ext2_update_dynamic_rev() function, I
> assumed it would be called as well. But indeed, mounting the old file
> system using the real ext2 driver retains its revision.
Thanks for trying that out and I'm glad that it still works ;)
> JFYI, this is what was changed by mounting and unmounting it using the
> ext2 driver:
>
> --- ramdisk.orig 2019-01-14 09:23:15.578434706 +0100
> +++ ramdisk.mounted-by-ext2 2019-01-14 09:23:16.362434253 +0100
> @@ -3,7 +3,7 @@
> 00000400 f8 00 00 00 78 05 00 00 00 00 00 00 20 00 00 00 |....x....... ...|
> 00000410 09 00 00 00 01 00 00 00 00 00 00 00 00 00 00 00 |................|
> 00000420 00 20 00 00 00 20 00 00 f8 00 00 00 f7 5e a3 32 |. ... .......^.2|
> -00000430 9e 5e a3 32 03 00 14 00 53 ef 01 00 01 00 00 00 |.^.2....S.......|
> +00000430 84 46 3c 5c 04 00 14 00 53 ef 01 00 01 00 00 00 |.F<\....S.......|
> 00000440 53 5d a3 32 00 4e ed 00 00 00 00 00 00 00 00 00 |S].2.N..........|
> 00000450 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
> 00000460 00 00 00 00 00 00 00 00 87 6b 6d 86 4c 96 11 d0 |.........km.L...|
>
> Which is just the last write time, and mount count, as expected.
> Interestingly, the last mount time was not updated.
Yeah, that looks like a bug that got introduced in 269c8db30cf5b6 "ext2:
Set the write time in ext2_sync_fs()" in 2010. I'll fix it. Thanks for
report.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2019-01-14 12:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-12 9:43 Geert Uytterhoeven
2019-01-13 0:20 ` Andreas Dilger
2019-01-14 10:23 ` Geert Uytterhoeven
2019-01-14 12:50 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190114125017.GI13316@quack2.suse.cz \
--to=jack@suse.cz \
--cc=adilger@dilger.ca \
--cc=geert@linux-m68k.org \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®