From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH]: xarray: Fix potential out of bounds access
Date: Mon, 14 Jan 2019 22:14:18 +0300 [thread overview]
Message-ID: <20190114191418.GG17906@uranus.lan> (raw)
In-Reply-To: <20190114190119.GZ6310@bombadil.infradead.org>
On Mon, Jan 14, 2019 at 11:01:20AM -0800, Matthew Wilcox wrote:
> On Mon, Jan 14, 2019 at 09:47:41PM +0300, Cyrill Gorcunov wrote:
> > Since the mark is used as an array index we should use
> > preincrement to not access the XA_MARK_MAX index.
>
> But XA_MARK_MAX is inclusive:
>
> include/linux/xarray.h:#define XA_MARK_MAX XA_MARK_2
Indeed, I misread the variable name.
> so we actually want to access XA_MARK_MAX. Now, we don't have a test
> in the test-suite that fails as a result of your patch, so that needs to get
> fixed. How about this:
Looks great. Thank you!
prev parent reply other threads:[~2019-01-14 19:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 18:47 Cyrill Gorcunov
2019-01-14 19:01 ` Matthew Wilcox
2019-01-14 19:14 ` Cyrill Gorcunov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190114191418.GG17906@uranus.lan \
--to=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome