From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1977C43387 for ; Tue, 15 Jan 2019 02:20:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AADB220659 for ; Tue, 15 Jan 2019 02:20:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727872AbfAOCUR (ORCPT ); Mon, 14 Jan 2019 21:20:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53244 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727273AbfAOCUR (ORCPT ); Mon, 14 Jan 2019 21:20:17 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 328C23D95D; Tue, 15 Jan 2019 02:20:17 +0000 (UTC) Received: from redhat.com (ovpn-124-229.rdu2.redhat.com [10.10.124.229]) by smtp.corp.redhat.com (Postfix) with SMTP id 54EB3100194B; Tue, 15 Jan 2019 02:20:16 +0000 (UTC) Date: Mon, 14 Jan 2019 21:20:15 -0500 From: "Michael S. Tsirkin" To: Wei Wang Cc: Cornelia Huck , Jason Wang , virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, virtio-dev@lists.oasis-open.org, Halil Pasic Subject: Re: [PATCH 1/2] virtio: fix virtio_config_ops description Message-ID: <20190114211953-mutt-send-email-mst@kernel.org> References: <20190103160804.21438-1-cohuck@redhat.com> <20190103160804.21438-2-cohuck@redhat.com> <20190114150958.39a4a56a.cohuck@redhat.com> <5C3D424B.70400@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5C3D424B.70400@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 15 Jan 2019 02:20:17 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 15, 2019 at 10:15:39AM +0800, Wei Wang wrote: > On 01/14/2019 10:09 PM, Cornelia Huck wrote: > > On Thu, 3 Jan 2019 17:08:03 +0100 > > Cornelia Huck wrote: > > > > > - get_features has returned 64 bits since commit d025477368792 > > > ("virtio: add support for 64 bit features.") > > > - properly mark all optional callbacks > > > > > > Signed-off-by: Cornelia Huck > > > --- > > > include/linux/virtio_config.h | 8 ++++---- > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > > > diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h > > > index 32baf8e26735..7087ef946ba7 100644 > > > --- a/include/linux/virtio_config.h > > > +++ b/include/linux/virtio_config.h > > > @@ -22,7 +22,7 @@ struct irq_affinity; > > > * offset: the offset of the configuration field > > > * buf: the buffer to read the field value from. > > > * len: the length of the buffer > > > - * @generation: config generation counter > > > + * @generation: config generation counter (optional) > > > * vdev: the virtio_device > > > * Returns the config generation counter > > > * @get_status: read the status byte > > > @@ -48,17 +48,17 @@ struct irq_affinity; > > > * @del_vqs: free virtqueues found by find_vqs(). > > > * @get_features: get the array of feature bits for this device. > > > * vdev: the virtio_device > > > - * Returns the first 32 feature bits (all we currently need). > > > + * Returns the first 64 feature bits (all we currently need). > > > * @finalize_features: confirm what device features we'll be using. > > > * vdev: the virtio_device > > > * This gives the final feature bits for the device: it can change > > > * the dev->feature bits if it wants. > > > * Returns 0 on success or error status > > > - * @bus_name: return the bus name associated with the device > > > + * @bus_name: return the bus name associated with the device (optional) > > > * vdev: the virtio_device > > > * This returns a pointer to the bus name a la pci_name from which > > > * the caller can then copy. > > > - * @set_vq_affinity: set the affinity for a virtqueue. > > > + * @set_vq_affinity: set the affinity for a virtqueue (optional). > > > * @get_vq_affinity: get the affinity for a virtqueue (optional). > > > */ > > > typedef void vq_callback_t(struct virtqueue *); > > Ping. Any feedback on that patch? > > Reviewed-by: Wei Wang > > Best, > Wei Pushed already, can't add tags. Sorry about that. -- MST