mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@iki.fi>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/5] ov7670 fixes
Date: Tue, 15 Jan 2019 13:24:13 +0200	[thread overview]
Message-ID: <20190115112413.yvwikkeoiynmsuh7@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <23ea680af226991402a30dd02bacb1dce0c998f8.camel@v3.sk>

On Tue, Jan 15, 2019 at 12:12:56PM +0100, Lubomir Rintel wrote:
> On Tue, 2019-01-15 at 12:40 +0200, Sakari Ailus wrote:
> > On Tue, Jan 15, 2019 at 09:54:43AM +0100, Lubomir Rintel wrote:
> > > Hi,
> > > 
> > > here are the ov7670 patches originally from the "media: make Marvell camera
> > > work on DT-based OLPC XO-1.75" updated to apply cleanly on top of
> > > <git://linuxtv.org/sailus/media_tree.git> master as requested.
> > > 
> > > I've also added "ov7670: Remove useless use of a ret variable" with my Ack
> > > slapped on it.
> > 
> > Hi Lubomir,
> > 
> > It seems the end result compiles but the intermedia patches do not. Could
> > you resend, please? I'll replace the patches in my tree with a new version
> > then...
> 
> Seems like the order got messed up. It should be sufficient to reorder
> the patches like this:
> 
> pick f42ae764598a ov7670: Remove useless use of a ret variable
> pick 5be2efe0e5bb media: ov7670: split register setting from set_fmt() logic
> pick 38eed963866e media: ov7670: split register setting from set_framerate() logic
> pick 97be3c31de46 media: ov7670: hook s_power onto v4l2 core
> pick 56c292d92642 media: ov7670: control clock along with power
> 
> (With "git rebase -i 87680151c22eee5b3bb6361fb8d18d765a9d8aff")

Oh well. Done; let's see if that works better...

-- 
Sakari Ailus

      reply	other threads:[~2019-01-15 11:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-15  8:54 Lubomir Rintel
2019-01-15  8:54 ` [PATCH v4 1/5] ov7670: Remove useless use of a ret variable Lubomir Rintel
2019-01-15  8:54 ` [PATCH v4 2/5] media: ov7670: hook s_power onto v4l2 core Lubomir Rintel
2019-01-15  8:54 ` [PATCH v4 3/5] media: ov7670: control clock along with power Lubomir Rintel
2019-01-15  8:54 ` [PATCH v4 4/5] media: ov7670: split register setting from set_fmt() logic Lubomir Rintel
2019-01-15  8:54 ` [PATCH v4 5/5] media: ov7670: split register setting from set_framerate() logic Lubomir Rintel
2019-01-15  9:07   ` Sakari Ailus
2019-01-15 10:40 ` [PATCH v4 0/5] ov7670 fixes Sakari Ailus
2019-01-15 11:12   ` Lubomir Rintel
2019-01-15 11:24     ` Sakari Ailus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190115112413.yvwikkeoiynmsuh7@valkosipuli.retiisi.org.uk \
    --to=sakari.ailus@iki.fi \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=lkundrak@v3.sk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®