From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: George Hilliard <thirtythreeforty@gmail.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
NeilBrown <neil@brown.name>,
sergio.paracuellos@gmail.com
Subject: Re: [PATCH v3] staging: Mediatek: Use individual config flags in Makefile
Date: Tue, 15 Jan 2019 18:20:09 +0100 [thread overview]
Message-ID: <20190115172009.GB30853@kroah.com> (raw)
In-Reply-To: <20190115170221.26693-1-thirtythreeforty@gmail.com>
On Tue, Jan 15, 2019 at 10:02:21AM -0700, George Hilliard wrote:
> These drivers can be useful on other MT76xx SoCs, which have compatible
> peripherals. The drivers were selectable in Kconfig, but they were
> quietly excluded from the build because the SOC_MT7621 chip was not
> selected. So, make the Makefiles use the same flags as Kconfig for
> these drivers.
>
> mt7621-dma and mt7621-dts are left alone because they truly do require
> that SoC.
>
> I have personally confirmed that the mt7621-spi driver works on the
> MT7688, which was what prompted this change.
>
> Cc: linux-kernel@vger.kernel.org
> Cc: devel@driverdev.osuosl.org
> Cc: NeilBrown <neil@brown.name>
> Cc: sergio.paracuellos@gmail.com
> Signed-off-by: George Hilliard <thirtythreeforty@gmail.com>
> ---
> drivers/staging/Makefile | 14 +++++++-------
> drivers/staging/mt7621-pci-phy/Makefile | 2 +-
> drivers/staging/mt7621-pci/Makefile | 2 +-
> 3 files changed, 9 insertions(+), 9 deletions(-)
What changed from v2 and v1? That always goes below the --- line.
Please fix that up and resend v4.
thanks,
greg k-h
next prev parent reply other threads:[~2019-01-15 17:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CACmrr9gHucWaWtz07kQms6AsquLKAHbK+_Q0kF=92RGo6HmAFA@mail.gmail.com>
2019-01-11 0:43 ` [PATCH v2 1/2] Move ralink-gdma to its own directory thirtythreeforty
2019-01-11 0:43 ` [PATCH v2 2/2] Mediatek staging: Use individual config flags in Makefile thirtythreeforty
2019-01-15 15:30 ` [PATCH v2 2/2] staging: Mediatek: " Greg Kroah-Hartman
2019-01-15 17:02 ` [PATCH v3] " George Hilliard
2019-01-15 17:20 ` Greg Kroah-Hartman [this message]
2019-01-15 17:29 ` [PATCH v4] " George Hilliard
2019-01-15 17:43 ` Greg Kroah-Hartman
2019-01-16 6:48 ` [PATCH v5] " George Hilliard
2019-01-16 4:43 ` [PATCH v4] " kbuild test robot
2019-01-15 17:32 ` [PATCH v3] " George Hilliard
2019-01-11 1:21 ` [PATCH v2 1/2] Move ralink-gdma to its own directory NeilBrown
2019-01-11 2:13 ` George Hilliard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190115172009.GB30853@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil@brown.name \
--cc=sergio.paracuellos@gmail.com \
--cc=thirtythreeforty@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome