mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefan Agner <stefan@agner.ch>
To: timur@kernel.org, nicoleotsuka@gmail.com, Xiubo.Lee@gmail.com
Cc: fabio.estevam@nxp.com, lgirdwood@gmail.com, broonie@kernel.org,
	perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
	linux-kernel@vger.kernel.org, Stefan Agner <stefan@agner.ch>,
	Daniel Baluta <daniel.baluta@nxp.com>
Subject: [PATCH v2 1/5] ASoC: imx-sgtl5000: put of nodes if finding codec fails
Date: Fri, 18 Jan 2019 10:06:52 +0100	[thread overview]
Message-ID: <20190118090656.14201-1-stefan@agner.ch> (raw)

Make sure to properly put the of node in case finding the codec
fails.

Fixes: 81e8e4926167 ("ASoC: fsl: add sgtl5000 clock support for imx-sgtl5000")
Signed-off-by: Stefan Agner <stefan@agner.ch>
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
---
Changes in v2:
- Reordered patches, make sure this is the first in the patchset

--
Stefan

 sound/soc/fsl/imx-sgtl5000.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sound/soc/fsl/imx-sgtl5000.c b/sound/soc/fsl/imx-sgtl5000.c
index c29200cf755a..594bde3b0ded 100644
--- a/sound/soc/fsl/imx-sgtl5000.c
+++ b/sound/soc/fsl/imx-sgtl5000.c
@@ -111,7 +111,8 @@ static int imx_sgtl5000_probe(struct platform_device *pdev)
 	codec_dev = of_find_i2c_device_by_node(codec_np);
 	if (!codec_dev) {
 		dev_err(&pdev->dev, "failed to find codec platform device\n");
-		return -EPROBE_DEFER;
+		ret = -EPROBE_DEFER;
+		goto fail;
 	}
 
 	data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
-- 
2.20.1


             reply	other threads:[~2019-01-18  9:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-18  9:06 Stefan Agner [this message]
2019-01-18  9:06 ` [PATCH v2 2/5] ASoC: imx-sgtl5000: lower log level for potential probe deferral cases Stefan Agner
2019-01-18 10:41   ` [alsa-devel] " Fabio Estevam
2019-01-18  9:06 ` [PATCH v2 3/5] ASoC: imx-sgtl5000: don't print EPROBE_DEFER as error Stefan Agner
2019-01-18 10:42   ` [alsa-devel] " Fabio Estevam
2019-01-18  9:06 ` [PATCH v2 4/5] ASoC: fsl_spdif: " Stefan Agner
2019-01-18 10:42   ` [alsa-devel] " Fabio Estevam
2019-01-18  9:06 ` [PATCH v2 5/5] ASoC: imx-spdif: " Stefan Agner
2019-01-18 10:43   ` [alsa-devel] " Fabio Estevam
2019-01-18 10:41 ` [alsa-devel] [PATCH v2 1/5] ASoC: imx-sgtl5000: put of nodes if finding codec fails Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190118090656.14201-1-stefan@agner.ch \
    --to=stefan@agner.ch \
    --cc=Xiubo.Lee@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=daniel.baluta@nxp.com \
    --cc=fabio.estevam@nxp.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicoleotsuka@gmail.com \
    --cc=perex@perex.cz \
    --cc=timur@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®