From: "Moger, Babu" <Babu.Moger@amd.com>
To: "fenghua.yu@intel.com" <fenghua.yu@intel.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"reinette.chatre@intel.com" <reinette.chatre@intel.com>,
"Moger, Babu" <Babu.Moger@amd.com>,
"james.morse@arm.com" <james.morse@arm.com>,
"xiaochen.shen@intel.com" <xiaochen.shen@intel.com>,
"ravi.v.shankar@intel.com" <ravi.v.shankar@intel.com>,
"sai.praneeth.prakhya@intel.com" <sai.praneeth.prakhya@intel.com>,
"arshiya.hayatkhan.pathan@intel.com"
<arshiya.hayatkhan.pathan@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>
Subject: [PATCH v5 13/13] selftests/resctrl: Disable MBA and MBM tests for AMD
Date: Fri, 18 Jan 2019 18:27:17 +0000 [thread overview]
Message-ID: <20190118182646.16594-14-babu.moger@amd.com> (raw)
In-Reply-To: <20190118182646.16594-1-babu.moger@amd.com>
For now, disable MBA and MBM tests for AMD. Deciding test pass/fail
is not clear right now. We can enable when we have some clarity.
Signed-off-by: Babu Moger <babu.moger@amd.com>
---
tools/testing/selftests/resctrl/cat_test.c | 2 +-
tools/testing/selftests/resctrl/resctrl_tests.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/resctrl/cat_test.c b/tools/testing/selftests/resctrl/cat_test.c
index 57d501d..badf2d1 100644
--- a/tools/testing/selftests/resctrl/cat_test.c
+++ b/tools/testing/selftests/resctrl/cat_test.c
@@ -69,7 +69,7 @@ static void show_cache_info(unsigned long sum_llc_perf_miss, int no_of_bits,
printf("Allocated cache lines: %lu \t", allocated_cache_lines);
printf("Percent diff=%d \t", abs((int)diff_percent));
- if (abs((int)diff_percent) > MAX_DIFF_PERCENT)
+ if (genuine_intel && (abs((int)diff_percent) > MAX_DIFF_PERCENT))
printf("Failed\n");
else
printf("Passed\n");
diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testing/selftests/resctrl/resctrl_tests.c
index e8cbcd5..b12f2c5 100644
--- a/tools/testing/selftests/resctrl/resctrl_tests.c
+++ b/tools/testing/selftests/resctrl/resctrl_tests.c
@@ -202,7 +202,7 @@ int main(int argc, char **argv)
sprintf(bw_report, "reads");
sprintf(bm_type, "fill_buf");
- if (mbm_test) {
+ if (genuine_intel && mbm_test) {
printf("\nMBM BW Change Starting..\n");
if (!has_ben)
sprintf(benchmark_cmd[5], "%s", "mbm");
@@ -212,7 +212,7 @@ int main(int argc, char **argv)
mbm_test_cleanup();
}
- if (mba_test) {
+ if (genuine_intel && mba_test) {
printf("\nMBA Schemata Change Starting..\n");
if (!has_ben)
sprintf(benchmark_cmd[5], "%s", "mba");
--
1.8.3.1
prev parent reply other threads:[~2019-01-18 18:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 18:27 [PATCH v5 00/13] selftests/resctrl: Add resctrl selftest Moger, Babu
2019-01-18 18:27 ` [PATCH v5 01/13] selftests/resctrl: Add README for resctrl tests Moger, Babu
2019-01-18 18:27 ` [PATCH v5 02/13] selftests/resctrl: Add basic resctrl file system operations and data Moger, Babu
2019-01-18 18:27 ` [PATCH v5 03/13] selftests/resctrl: Read memory bandwidth from perf IMC counter and from resctrl file system Moger, Babu
2019-01-18 18:27 ` [PATCH v5 04/13] selftests/resctrl: Add callback to start a benchmark Moger, Babu
2019-01-18 18:27 ` [PATCH v5 05/13] selftests/resctrl: Add built in benchmark Moger, Babu
2019-01-18 18:27 ` [PATCH v5 06/13] selftests/resctrl: Add MBM test Moger, Babu
2019-01-18 18:27 ` [PATCH v5 07/13] selftests/resctrl: Add MBA test Moger, Babu
2019-01-18 18:27 ` [PATCH v5 08/13] selftests/resctrl Add Cache QoS Monitoring (CQM) selftest Moger, Babu
2019-01-18 18:27 ` [PATCH v5 09/13] selftests/resctrl: Add Cache Allocation Technology (CAT) selftest Moger, Babu
2019-01-18 18:27 ` [PATCH v5 10/13] selftests/resctrl: Add the test in MAINTAINERS Moger, Babu
2019-01-18 18:27 ` [PATCH v5 11/13] selftests/resctrl: Add vendor detection mechanism Moger, Babu
2019-01-18 18:27 ` [PATCH v5 12/13] selftests/resctrl: Use cache index3 id for AMD schemata masks Moger, Babu
2019-01-18 18:27 ` Moger, Babu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190118182646.16594-14-babu.moger@amd.com \
--to=babu.moger@amd.com \
--cc=arshiya.hayatkhan.pathan@intel.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=ravi.v.shankar@intel.com \
--cc=reinette.chatre@intel.com \
--cc=sai.praneeth.prakhya@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=xiaochen.shen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®