Re: [PATCH] ASoC: fsl_sai: Remove expensive print in irq handler

[Nicolin Chen <nicoleotsuka@gmail.com>]

On Fri, Jan 18, 2019 at 02:26:46PM +0000, Daniel Baluta wrote:
> From: Shengjiu Wang <shengjiu.wang@nxp.com>
> 
> When stopping audio, ASoC will first stop DMA then CPU DAI.
> Sometimes there is a delay between DMA stop and CPU DAI stop, which
> triggers an underrun error. Now, because of the delay introduced
> by dev_err another underrun error will occur causing a vicious circle
> making impossible to stop CPU DAI.
> 
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>

Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>

> ---
>  sound/soc/fsl/fsl_sai.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c
> index 4163f2cfc06f..db9e0872f73d 100644
> --- a/sound/soc/fsl/fsl_sai.c
> +++ b/sound/soc/fsl/fsl_sai.c
> @@ -62,10 +62,10 @@ static irqreturn_t fsl_sai_isr(int irq, void *devid)
>  		dev_dbg(dev, "isr: Start of Tx word detected\n");
>  
>  	if (flags & FSL_SAI_CSR_SEF)
> -		dev_warn(dev, "isr: Tx Frame sync error detected\n");
> +		dev_dbg(dev, "isr: Tx Frame sync error detected\n");
>  
>  	if (flags & FSL_SAI_CSR_FEF) {
> -		dev_warn(dev, "isr: Transmit underrun detected\n");
> +		dev_dbg(dev, "isr: Transmit underrun detected\n");
>  		/* FIFO reset for safety */
>  		xcsr |= FSL_SAI_CSR_FR;
>  	}
> @@ -96,10 +96,10 @@ static irqreturn_t fsl_sai_isr(int irq, void *devid)
>  		dev_dbg(dev, "isr: Start of Rx word detected\n");
>  
>  	if (flags & FSL_SAI_CSR_SEF)
> -		dev_warn(dev, "isr: Rx Frame sync error detected\n");
> +		dev_dbg(dev, "isr: Rx Frame sync error detected\n");
>  
>  	if (flags & FSL_SAI_CSR_FEF) {
> -		dev_warn(dev, "isr: Receive overflow detected\n");
> +		dev_dbg(dev, "isr: Receive overflow detected\n");
>  		/* FIFO reset for safety */
>  		xcsr |= FSL_SAI_CSR_FR;
>  	}
> -- 
> 2.17.1
>