mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Luis Chamberlain <mcgrof@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>, akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] lib/test_kmod: Potential double free in error handling
Date: Tue, 22 Jan 2019 11:47:17 -0800	[thread overview]
Message-ID: <20190122194716.GC11489@garbanzo.do-not-panic.com> (raw)
In-Reply-To: <20190121140011.GA14283@kadam>

On Mon, Jan 21, 2019 at 05:00:11PM +0300, Dan Carpenter wrote:
> There is a copy and paste bug so we set "config->test_driver" to NULL
> twice instead of setting "config->test_fs".  Smatch complains that it
> leads to a double free:
> 
> lib/test_kmod.c:840 __kmod_config_init() warn: 'config->test_fs' double freed
> 
> Fixes: d9c6a72d6fa2 ("kmod: add test driver to stress test the module loader")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks!

Acked-by: Luis Chamberlain <mcgrof@kernel.org>

 Luis

      reply	other threads:[~2019-01-22 19:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-21 14:00 Dan Carpenter
2019-01-22 19:47 ` Luis Chamberlain [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190122194716.GC11489@garbanzo.do-not-panic.com \
    --to=mcgrof@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome