From: Greg KH <gregkh@linuxfoundation.org>
To: wen.yang99@zte.com.cn
Cc: arnd@arndb.de, davem@davemloft.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] char/rtc: fix object reference leaks in rtc_init
Date: Wed, 23 Jan 2019 13:02:08 +0100 [thread overview]
Message-ID: <20190123120208.GB31385@kroah.com> (raw)
In-Reply-To: <201901231822458570930@zte.com.cn>
On Wed, Jan 23, 2019 at 06:22:45PM +0800, wen.yang99@zte.com.cn wrote:
> The device node iterators perform an of_node_get on each iteration, so a
> jump out of the loop requires an of_node_put.
> The of_find_device_by_node() takes a reference to the underlying device
> structure, we also should release that reference.
> This patch fixes those 2 issues.
> Fixes: 75081322c ("sparc32: Convert PC RTC probing to pure OF driver")
>
> Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Your "From:" line in your email does not match this :(
Please fix up your email client to have it match and resend.
thanks,
greg k-h
parent reply other threads:[~2019-01-23 12:02 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <201901231822458570930@zte.com.cn>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190123120208.GB31385@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=wen.yang99@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®