mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Chen Yu <chenyu56@huawei.com>, Jun Li <jun.li@nxp.com>,
	Hans de Goede <hdegoede@redhat.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/8] platform/x86: intel_cht_int33fe: Remove connection for the alt mode mux
Date: Fri, 25 Jan 2019 16:15:12 +0300	[thread overview]
Message-ID: <20190125131519.88416-2-heikki.krogerus@linux.intel.com> (raw)
In-Reply-To: <20190125131519.88416-1-heikki.krogerus@linux.intel.com>

Driver for fusb302 does not support alternate modes, so the
connection is not really needed for now. Removing that
connection description allows us to improve the USB Type-C
mux API.

Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
---
 drivers/platform/x86/intel_cht_int33fe.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/drivers/platform/x86/intel_cht_int33fe.c b/drivers/platform/x86/intel_cht_int33fe.c
index 02bc74608cf3..fbd24daa7f8d 100644
--- a/drivers/platform/x86/intel_cht_int33fe.c
+++ b/drivers/platform/x86/intel_cht_int33fe.c
@@ -32,7 +32,7 @@ struct cht_int33fe_data {
 	struct i2c_client *fusb302;
 	struct i2c_client *pi3usb30532;
 	/* Contain a list-head must be per device */
-	struct device_connection connections[5];
+	struct device_connection connections[4];
 };
 
 /*
@@ -178,12 +178,9 @@ static int cht_int33fe_probe(struct platform_device *pdev)
 	data->connections[1].endpoint[0] = "port0";
 	data->connections[1].endpoint[1] = "i2c-pi3usb30532";
 	data->connections[1].id = "typec-mux";
-	data->connections[2].endpoint[0] = "port0";
-	data->connections[2].endpoint[1] = "i2c-pi3usb30532";
-	data->connections[2].id = "idff01m01";
-	data->connections[3].endpoint[0] = "i2c-fusb302";
-	data->connections[3].endpoint[1] = "intel_xhci_usb_sw-role-switch";
-	data->connections[3].id = "usb-role-switch";
+	data->connections[2].endpoint[0] = "i2c-fusb302";
+	data->connections[2].endpoint[1] = "intel_xhci_usb_sw-role-switch";
+	data->connections[2].id = "usb-role-switch";
 
 	device_connections_add(data->connections);
 
-- 
2.20.1


  reply	other threads:[~2019-01-25 13:15 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-25 13:15 [PATCH 0/8] device connection: Add support for device graphs Heikki Krogerus
2019-01-25 13:15 ` Heikki Krogerus [this message]
2019-01-28  9:45   ` [PATCH 1/8] platform/x86: intel_cht_int33fe: Remove connection for the alt mode mux Andy Shevchenko
2019-01-28 10:44     ` Hans de Goede
2019-01-28 15:27       ` Heikki Krogerus
2019-01-31 10:04         ` Hans de Goede
2019-01-25 13:15 ` [PATCH 2/8] usb: typec: Rationalize the API for the muxes Heikki Krogerus
2019-01-28  9:50   ` Andy Shevchenko
2019-01-28 15:28     ` Heikki Krogerus
2019-01-25 13:15 ` [PATCH 3/8] device connection: Add fwnode member to struct device_connection Heikki Krogerus
2019-01-25 13:15 ` [PATCH 4/8] usb: typec: mux: Find the muxes by also matching against the device node Heikki Krogerus
2019-01-28  9:53   ` Andy Shevchenko
2019-01-28 15:46     ` Heikki Krogerus
2019-01-28 16:17       ` Andy Shevchenko
2019-01-25 13:15 ` [PATCH 5/8] usb: roles: " Heikki Krogerus
2019-01-25 13:15 ` [PATCH 6/8] usb: typec: Find the ports " Heikki Krogerus
2019-01-25 13:15 ` [PATCH 7/8] device connection: Prepare support for firmware described connections Heikki Krogerus
2019-01-25 13:15 ` [PATCH 8/8] device connection: Find device connections also from device graphs Heikki Krogerus
2019-01-28  9:58   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190125131519.88416-2-heikki.krogerus@linux.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=chenyu56@huawei.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=jun.li@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome