From: Dan Carpenter <dan.carpenter@oracle.com>
To: Gao Xiang <gaoxiang25@huawei.com>
Cc: Chao Yu <yuchao0@huawei.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-erofs@lists.ozlabs.org,
Chao Yu <chao@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
weidu.du@huawei.com, Fang Wei <fangwei1@huawei.com>,
Miao Xie <miaoxie@huawei.com>
Subject: Re: [PATCH 1/2] staging: erofs: use xattr_prefix to wrap up
Date: Fri, 25 Jan 2019 16:26:14 +0300 [thread overview]
Message-ID: <20190125132614.GB1795@kadam> (raw)
In-Reply-To: <20190125115103.47250-1-gaoxiang25@huawei.com>
On Fri, Jan 25, 2019 at 07:51:03PM +0800, Gao Xiang wrote:
> Let's use xattr_prefix instead of open code.
> No logic changes.
>
> Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
> ---
> drivers/staging/erofs/xattr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/erofs/xattr.c b/drivers/staging/erofs/xattr.c
> index 1c9498e38f0e..eca65df46133 100644
> --- a/drivers/staging/erofs/xattr.c
> +++ b/drivers/staging/erofs/xattr.c
> @@ -521,7 +521,7 @@ static int xattr_entrylist(struct xattr_iter *_it,
> return 1;
>
> /* Note that at least one of 'prefix' and 'name' should be non-NULL */
The comment is sort of confusing now.
> - prefix = h->prefix != NULL ? h->prefix : h->name;
> + prefix = xattr_prefix(h);
> prefix_len = strlen(prefix);
regards,
dan carpenter
next prev parent reply other threads:[~2019-01-25 13:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 11:51 Gao Xiang
2019-01-25 12:01 ` [PATCH 2/2] staging: erofs: complete POSIX ACL support Gao Xiang
2019-01-25 13:30 ` Dan Carpenter
2019-01-25 13:54 ` Gao Xiang
2019-01-25 13:26 ` Dan Carpenter [this message]
2019-01-25 13:58 ` [PATCH 1/2] staging: erofs: use xattr_prefix to wrap up Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190125132614.GB1795@kadam \
--to=dan.carpenter@oracle.com \
--cc=chao@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=fangwei1@huawei.com \
--cc=gaoxiang25@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miaoxie@huawei.com \
--cc=weidu.du@huawei.com \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®