From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 723C8C282C0 for ; Fri, 25 Jan 2019 18:13:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4B313218A6 for ; Fri, 25 Jan 2019 18:13:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729407AbfAYSNG (ORCPT ); Fri, 25 Jan 2019 13:13:06 -0500 Received: from foss.arm.com ([217.140.101.70]:52260 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726273AbfAYSNF (ORCPT ); Fri, 25 Jan 2019 13:13:05 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A46A7EBD; Fri, 25 Jan 2019 10:13:04 -0800 (PST) Received: from arrakis.emea.arm.com (arrakis.cambridge.arm.com [10.1.196.113]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2AD4F3F5C1; Fri, 25 Jan 2019 10:13:03 -0800 (PST) Date: Fri, 25 Jan 2019 18:13:00 +0000 From: Catalin Marinas To: Greg Kroah-Hartman Cc: Kevin Hilman , Russell King , Will Deacon , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Marc Zyngier , Peng Donglin Subject: Re: [PATCH 1/4] arm64: dump: no need to check return value of debugfs_create functions Message-ID: <20190125181300.GN25901@arrakis.emea.arm.com> References: <20190122144114.9816-1-gregkh@linuxfoundation.org> <20190122144114.9816-2-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190122144114.9816-2-gregkh@linuxfoundation.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 22, 2019 at 03:41:11PM +0100, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Marc Zyngier > Cc: Peng Donglin > Cc: > Signed-off-by: Greg Kroah-Hartman Acked-by: Catalin Marinas