From: Ioan-Adrian Ratiu <adi@adirat.com>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: [RFC][PATCH] Revert "ARM: dts: bcm2837: Fix polarity of wifi reset GPIOs"
Date: Sun, 27 Jan 2019 22:28:13 +0200 [thread overview]
Message-ID: <20190127202813.29493-1-adi@adirat.com> (raw)
This reverts commit bea8a160c621d19f7f78b13e14e03f4b8e44cd4b.
Contrary to what the commit message says, on my rpi 3 b v1.2 changing
the polarity causes the exact behaviour this commit intends to fix, as
described at the referenced link below (wlan0 disapears).
With reset-gpios = ... GPIO_ACTIVE_HIGH, brcmfmac errors in dmesg:
[ 7.977512] brcmfmac: brcmf_sdio_bus_sleep: error while changing bus sleep state -110
[ 7.977623] brcmfmac: brcmf_sdio_txfail: sdio error, abort command and terminate frame
[ 7.978007] brcmfmac: brcmf_sdio_txfail: sdio error, abort command and terminate frame
[ 7.978377] brcmfmac: brcmf_sdio_txfail: sdio error, abort command and terminate frame
[ 7.978724] brcmfmac: brcmf_sdio_dpc: failed backplane access over SDIO, halting operation
[ 7.978734] brcmfmac: brcmf_proto_bcdc_query_dcmd: brcmf_proto_bcdc_msg failed w/status -110
[ 7.978747] brcmfmac: brcmf_cfg80211_get_channel: chanspec failed (-110)
[ 7.982817] brcmfmac: brcmf_sdio_bus_sleep: error while changing bus sleep state -110
[ 7.982880] brcmfmac: brcmf_sdio_txfail: sdio error, abort command and terminate frame
[ 7.983255] brcmfmac: brcmf_sdio_txfail: sdio error, abort command and terminate frame
The only solution I currently have is to revert and everything works
as expected and as before changing the polarity.
Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911443
Signed-off-by: Ioan-Adrian Ratiu <adi@adirat.com>
---
arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts | 2 +-
arch/arm/boot/dts/bcm2837-rpi-3-b.dts | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts b/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
index 93762244be7f..4adb85e66be3 100644
--- a/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
+++ b/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
@@ -31,7 +31,7 @@
wifi_pwrseq: wifi-pwrseq {
compatible = "mmc-pwrseq-simple";
- reset-gpios = <&expgpio 1 GPIO_ACTIVE_LOW>;
+ reset-gpios = <&expgpio 1 GPIO_ACTIVE_HIGH>;
};
};
diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
index 89e6fd547c75..c318bcbc6ba7 100644
--- a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
+++ b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
@@ -26,7 +26,7 @@
wifi_pwrseq: wifi-pwrseq {
compatible = "mmc-pwrseq-simple";
- reset-gpios = <&expgpio 1 GPIO_ACTIVE_LOW>;
+ reset-gpios = <&expgpio 1 GPIO_ACTIVE_HIGH>;
};
};
--
2.20.1
next reply other threads:[~2019-01-27 20:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-27 20:28 Ioan-Adrian Ratiu [this message]
2019-01-27 20:33 ` Ioan-Adrian Ratiu
2019-01-27 21:02 ` Greg KH
2019-01-27 21:26 ` Stefan Wahren
2019-01-28 18:31 ` Ioan-Adrian Ratiu
2019-01-28 18:43 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190127202813.29493-1-adi@adirat.com \
--to=adi@adirat.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®