From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5ADDC282C8 for ; Mon, 28 Jan 2019 13:32:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9FDDC21738 for ; Mon, 28 Jan 2019 13:32:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726851AbfA1Ncp (ORCPT ); Mon, 28 Jan 2019 08:32:45 -0500 Received: from mx2.suse.de ([195.135.220.15]:43412 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726647AbfA1Ncp (ORCPT ); Mon, 28 Jan 2019 08:32:45 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id BDF36AF6F; Mon, 28 Jan 2019 13:32:43 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 812E7DA78C; Mon, 28 Jan 2019 14:32:10 +0100 (CET) Date: Mon, 28 Jan 2019 14:32:10 +0100 From: David Sterba To: YueHaibing Cc: clm@fb.com, josef@toxicpanda.com, dsterba@suse.com, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org Subject: Re: [PATCH -next] btrfs: remove unused function btrfs_sysfs_feature_update Message-ID: <20190128133210.GF2900@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, YueHaibing , clm@fb.com, josef@toxicpanda.com, dsterba@suse.com, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org References: <20190117084828.14440-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190117084828.14440-1-yuehaibing@huawei.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 17, 2019 at 04:48:28PM +0800, YueHaibing wrote: > There are no in-tree callers. I'd rather see the code fixed, the patch that used the function was reverted because it was not safe to call sysfs from various contexts. I have some wip.