From: Josh Poimboeuf <jpoimboe@redhat.com>
To: valdis.kletnieks@vt.edu
Cc: Peter Zijlstra <peterz@infradead.org>, linux-kernel@vger.kernel.org
Subject: Re: next-20190125 - objtool complains about dumpstack
Date: Mon, 28 Jan 2019 10:19:14 -0600 [thread overview]
Message-ID: <20190128161914.hc53qk6yplah6tl2@treble> (raw)
In-Reply-To: <1255.1548650410@turing-police.cc.vt.edu>
On Sun, Jan 27, 2019 at 11:40:10PM -0500, valdis.kletnieks@vt.edu wrote:
> On Sun, 27 Jan 2019 22:18:25 -0600, Josh Poimboeuf said:
> > On Sun, Jan 27, 2019 at 10:45:03PM -0500, valdis.kletnieks@vt.edu wrote:
> > > Seen in a build:
> > >
> > > CC arch/x86/kernel/dumpstack.o
> > > arch/x86/kernel/dumpstack.o: warning: objtool: oops_begin()+0x9: undefined stack state
> > > arch/x86/kernel/dumpstack.o: warning: objtool: oops_begin()+0x0: stack state mismatch: cfa1=6+16 cfa2=7+8
> > >
> > > Probably a gcc9 code generation that objtool doesn't know about?
> >
> > Can you share the .o file?
>
> Sure. Attached.
Thanks for reporting it. Here's the fix below. I'll submit an official
patch soon.
diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index 0414a0d52262..df9bd60153c9 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -165,6 +165,7 @@ static int __dead_end_function(struct objtool_file *file, struct symbol *func,
"fortify_panic",
"usercopy_abort",
"machine_real_restart",
+ "rewind_stack_do_exit",
};
if (func->bind == STB_WEAK)
prev parent reply other threads:[~2019-01-28 16:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 3:45 valdis.kletnieks
2019-01-28 4:18 ` Josh Poimboeuf
2019-01-28 4:40 ` valdis.kletnieks
2019-01-28 16:19 ` Josh Poimboeuf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190128161914.hc53qk6yplah6tl2@treble \
--to=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®