mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jan H. Schönherr" <jan@schnhrr.de>
To: Borislav Petkov <bp@alien8.de>, Ingo Molnar <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	x86@kernel.org
Cc: "Jan H. Schönherr" <jan@schnhrr.de>,
	"Paul Menzel" <pmenzel@molgen.mpg.de>,
	"Thomas Lendacky" <Thomas.Lendacky@amd.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] Fix TSC issues on (some) AMD Ryzen based systems
Date: Tue, 29 Jan 2019 11:23:27 +0100	[thread overview]
Message-ID: <20190129102329.27610-1-jan@schnhrr.de> (raw)

My newly acquired AMD Ryzen Threadripper based system seems to have
some TSC quirks, which go away once the system is up.

Given the discussion in https://lkml.org/lkml/2019/1/28/1356 
I don't seem to be the only one, and it does not seem to be
Threadripper specific.

The first patch addresses presumably SMI interruptions, that occur
on my system at a 60 Hz frequency. They take too long, making the
existing code fail. The patch makes that code more resilient.
(These interruptions go away at some point during boot; also proven
by the fact, that I don't have any TSC issues, when kexecing into
a new kernel.)

The second patch prevents TSC going unstable when resuming from S3.
This may have a similar source, but is certainly more weird: the
TSC is observed to go backwards on CPU0 by about 200 to 500 cycles
compared to other CPUs every once in a while, as long as its sibling
(CPU16 in my case) hasn't been resumed yet. (I did some experiments
with CPU hotplug before and after suspend, but apart from reproducing
the issue and verifying the "fix", I got nowhere.)

The patches are against v4.20.

Jan H. Schönherr (2):
  x86/tsc: Allow quick PIT calibration despite interruptions
  cpu/hotplug: Unfreeze sibling CPU first on resume from S3

 arch/x86/kernel/tsc.c | 80 +++++++++++++++++++++++++------------------
 kernel/cpu.c          | 34 ++++++++++++------
 2 files changed, 70 insertions(+), 44 deletions(-)

-- 
2.19.2


             reply	other threads:[~2019-01-29 10:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-29 10:23 Jan H. Schönherr [this message]
2019-01-29 10:23 ` [PATCH 1/2] x86/tsc: Allow quick PIT calibration despite interruptions Jan H. Schönherr
     [not found]   ` <5C50558B.8060405@schnhrr.de>
2019-01-29 22:28     ` Thomas Gleixner
2019-02-12 11:57       ` Thomas Gleixner
2019-02-14 21:48         ` Jan H. Schönherr
2019-01-29 10:23 ` [PATCH 2/2] cpu/hotplug: Unfreeze sibling CPU first on resume from S3 Jan H. Schönherr
2019-01-29 23:02   ` Thomas Gleixner
2019-01-29 19:33 ` [PATCH 0/2] Fix TSC issues on (some) AMD Ryzen based systems Paul Menzel
2019-01-29 19:37   ` Paul Menzel
2019-01-29 22:31     ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190129102329.27610-1-jan@schnhrr.de \
    --to=jan@schnhrr.de \
    --cc=Thomas.Lendacky@amd.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pmenzel@molgen.mpg.de \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®