mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johannes Weiner <hannes@cmpxchg.org>
To: Babu Moger <babu.moger@amd.com>, Borislav Petkov <bp@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] x86: avoid confusion over the new RESCTRL config prompt
Date: Tue, 29 Jan 2019 17:52:18 -0500	[thread overview]
Message-ID: <20190129225218.15441-1-hannes@cmpxchg.org> (raw)

"Resource Control" is a very broad term for this CPU feature, and a
term that is also associated with containers, cgroups etc. This can
easily cause confusion.

Make the user prompt more specific.

Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
---
 arch/x86/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

As somebody who works in "resource control", this prompt in oldconfig
certainly had me go wtf. Can we do something more specific?

Not insisting on this name, and I haven't renamed all the config
symbols yet, but we should probably fix this before 5.0 is released.

Thanks!

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 26387c7bf305..426677b759c0 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -447,11 +447,11 @@ config RETPOLINE
 	  support for full protection. The kernel may run slower.
 
 config X86_RESCTRL
-	bool "Resource Control support"
+	bool "x86 cache control support"
 	depends on X86 && (CPU_SUP_INTEL || CPU_SUP_AMD)
 	select KERNFS
 	help
-	  Enable Resource Control support.
+	  Enable x86 cache control support.
 
 	  Provide support for the allocation and monitoring of system resources
 	  usage by the CPU.
-- 
2.20.1


             reply	other threads:[~2019-01-29 22:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-29 22:52 Johannes Weiner [this message]
2019-01-29 23:08 ` Borislav Petkov
2019-01-29 23:46   ` Luck, Tony
2019-01-30 16:46   ` Johannes Weiner
2019-01-30 17:19     ` Borislav Petkov
2019-01-30 19:56       ` Johannes Weiner
2019-02-01 19:18         ` Luck, Tony
2019-02-02  0:06           ` Borislav Petkov
2019-02-02  9:45         ` [tip:x86/urgent] x86/resctrl: Avoid confusion over the new X86_RESCTRL config tip-bot for Johannes Weiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190129225218.15441-1-hannes@cmpxchg.org \
    --to=hannes@cmpxchg.org \
    --cc=babu.moger@amd.com \
    --cc=bp@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®