From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D713C282D7 for ; Wed, 30 Jan 2019 16:32:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 473BA20989 for ; Wed, 30 Jan 2019 16:32:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731931AbfA3QcC (ORCPT ); Wed, 30 Jan 2019 11:32:02 -0500 Received: from 8bytes.org ([81.169.241.247]:35976 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728008AbfA3QcC (ORCPT ); Wed, 30 Jan 2019 11:32:02 -0500 Received: by theia.8bytes.org (Postfix, from userid 1000) id 521375B8; Wed, 30 Jan 2019 17:32:01 +0100 (CET) Date: Wed, 30 Jan 2019 17:32:00 +0100 From: Joerg Roedel To: Peter Xu Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Jason Wang , Jerome Glisse Subject: Re: [PATCH 1/2] iommu/vt-d: Remove change_pte notifier Message-ID: <20190130163159.t2633rwpjbffjyvz@8bytes.org> References: <20190130055758.3994-1-peterx@redhat.com> <20190130055758.3994-2-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190130055758.3994-2-peterx@redhat.com> User-Agent: NeoMutt/20170421 (1.8.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 30, 2019 at 01:57:57PM +0800, Peter Xu wrote: > The change_pte() interface is tailored for PFN updates, while the > other notifier invalidate_range() should be enough for Intel IOMMU > cache flushing. Actually we've done similar thing for AMD IOMMU > already in 8301da53fbc1 ("iommu/amd: Remove change_pte mmu_notifier > call-back", 2014-07-30) but the Intel IOMMU driver still have it. > > Signed-off-by: Peter Xu Applied to x86/vt-d, thanks.