mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Ayush Mittal <ayush.m@samsung.com>
Cc: tj@kernel.org, linux-kernel@vger.kernel.org,
	pankaj.m@samsung.com, a.sahrawat@samsung.com,
	v.narang@samsung.com
Subject: Re: [PATCH 1/1] kernfs: Allocating memory for kernfs_iattrs with kmem_cache.
Date: Thu, 31 Jan 2019 13:32:05 +0100	[thread overview]
Message-ID: <20190131123205.GA20404@kroah.com> (raw)
In-Reply-To: <1548927785-40397-1-git-send-email-ayush.m@samsung.com>

On Thu, Jan 31, 2019 at 03:13:05PM +0530, Ayush Mittal wrote:
> @@ -414,4 +414,9 @@ void __init kernfs_init(void)
>  					      0,
>  					      SLAB_PANIC | SLAB_TYPESAFE_BY_RCU,
>  					      NULL);
> +	kernfs_iattrs_cache  = kmem_cache_create("kernfs_iattrs_cache",
> +					      sizeof(struct kernfs_iattrs),
> +					      0,
> +					      SLAB_PANIC | SLAB_TYPESAFE_BY_RCU,
> +					      NULL);
>  }

Are you sure the comment above this holds true for this new cache as
well?  Please document it as well as the other one was, and remove the
SLAB_ flags as needed.

thanks,

greg k-h

      reply	other threads:[~2019-01-31 12:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20190131095437epcas5p1501775cdfb469235c6ab9f6f9ab67898@epcas5p1.samsung.com>
2019-01-31  9:43 ` Ayush Mittal
2019-01-31 12:32   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190131123205.GA20404@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=a.sahrawat@samsung.com \
    --cc=ayush.m@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pankaj.m@samsung.com \
    --cc=tj@kernel.org \
    --cc=v.narang@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome