mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Axel Dörfler" <axeld@pinc-software.de>
To: Luis de Bethencourt <luisbg@kernel.org>,
	Salah Triki <salah.triki@gmail.com>,
	linux-kernel@vger.kernel.org
Cc: "Axel Dörfler" <axeld@pinc-software.de>
Subject: [PATCH] befs: Removed incorrect check
Date: Fri,  1 Feb 2019 14:48:01 +0100	[thread overview]
Message-ID: <20190201134801.19436-1-axeld@pinc-software.de> (raw)

The relation between ag_shift and blocks_per_ag is a bit more complex,
and also depends on the fs block size.
Since blocks_per_ag is not even being used, simply omit the check.

Signed-off-by: Axel Dörfler <axeld@pinc-software.de>
---
 fs/befs/super.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/fs/befs/super.c b/fs/befs/super.c
index 7c50025c9..29fa37557 100644
--- a/fs/befs/super.c
+++ b/fs/befs/super.c
@@ -99,13 +99,6 @@ befs_check_sb(struct super_block *sb)
 		return BEFS_ERR;
 	}
 
-
-	/* ag_shift also encodes the same information as blocks_per_ag in a
-	 * different way, non-fatal consistency check
-	 */
-	if ((1 << befs_sb->ag_shift) != befs_sb->blocks_per_ag)
-		befs_error(sb, "ag_shift disagrees with blocks_per_ag.");
-
 	if (befs_sb->log_start != befs_sb->log_end ||
 	    befs_sb->flags == BEFS_DIRTY) {
 		befs_error(sb, "Filesystem not clean! There are blocks in the "
-- 
2.17.1


                 reply	other threads:[~2019-02-01 13:54 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190201134801.19436-1-axeld@pinc-software.de \
    --to=axeld@pinc-software.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luisbg@kernel.org \
    --cc=salah.triki@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome