From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1188EC282D8 for ; Fri, 1 Feb 2019 14:37:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DEB6E218AC for ; Fri, 1 Feb 2019 14:37:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727910AbfBAOha convert rfc822-to-8bit (ORCPT ); Fri, 1 Feb 2019 09:37:30 -0500 Received: from mx2.suse.de ([195.135.220.15]:50824 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726282AbfBAOha (ORCPT ); Fri, 1 Feb 2019 09:37:30 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 76127ABEC; Fri, 1 Feb 2019 14:37:28 +0000 (UTC) Date: Fri, 1 Feb 2019 15:37:26 +0100 From: Thomas Bogendoerfer To: Christoph Hellwig Cc: Bjorn Helgaas , James Hogan , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-pci@vger.kernel.org, Lorenzo Pieralisi , Paul Burton , Ralf Baechle Subject: Re: [PATCH 7/7] MIPS: SGI-IP27: abstract chipset irq from bridge Message-Id: <20190201153726.e3ce44c4a3fb22f5f5d6bcf3@suse.de> In-Reply-To: <20190128162721.GA25378@infradead.org> References: <20190124174728.28812-1-tbogendoerfer@suse.de> <20190124174728.28812-8-tbogendoerfer@suse.de> <20190128133317.GD744@infradead.org> <20190128150135.66f85834ab80813e6dc5ddf5@suse.de> <20190128162721.GA25378@infradead.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 28 Jan 2019 08:27:21 -0800 Christoph Hellwig wrote: > On Mon, Jan 28, 2019 at 03:01:35PM +0100, Thomas Bogendoerfer wrote: > > On Mon, 28 Jan 2019 05:33:17 -0800 > > Christoph Hellwig wrote: > > > > > Shouldnt this just use chained irqchip drivers instead? > > > > you mean using irq_set_chained_handler() ? If yes, this IMHO doesn't look usefull > > because it's used for adding a secondary interrupt controller. But what I need > > is telling bridge ASIC to direct the xtalk IRQ packet to a specific HUB/HEART/BEDROCK > > from the HUB/HEART/BEDROCK specific code. And want to avoid dragging in bridge details > > to that specific code. > > Yes, but don't we have nested interrupt controllers here? Even if they > don't really do much in the fast path the setup does look chained to me. > Then again I'm not really an expert in the irq handling code nor in this > hardware, so maybe Thomas or Marc might have a better idea. found a presentation from Marc and what I need here is irqdomain hierarchy. Which meana converting the whole hub irq code to irqdomain first. Let's see how easy this will be:-) Thomas. -- SUSE Linux GmbH GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)