From: Greg KH <gregkh@linuxfoundation.org>
To: Pawel Laszczak <pawell@cadence.com>
Cc: devicetree@vger.kernel.org, mark.rutland@arm.com,
linux-usb@vger.kernel.org, hdegoede@redhat.com,
heikki.krogerus@linux.intel.com, andy.shevchenko@gmail.com,
robh+dt@kernel.org, rogerq@ti.com, linux-kernel@vger.kernel.org,
jbergsagel@ti.com, nsekhar@ti.com, nm@ti.com,
sureshp@cadence.com, peter.chen@nxp.com, pjez@cadence.com,
kurahul@cadence.com
Subject: Re: [PATCH v3 5/6] usb:cdns3 Add Cadence USB3 DRD Driver
Date: Mon, 4 Feb 2019 12:48:41 +0100 [thread overview]
Message-ID: <20190204114841.GD28608@kroah.com> (raw)
In-Reply-To: <1548935553-452-6-git-send-email-pawell@cadence.com>
On Thu, Jan 31, 2019 at 11:52:32AM +0000, Pawel Laszczak wrote:
> This patch introduce new Cadence USBSS DRD driver
> to linux kernel.
>
> The Cadence USBSS DRD Driver is a highly
> configurable IP Core which can be
> instantiated as Dual-Role Device (DRD),
> Peripheral Only and Host Only (XHCI)
> configurations.
>
> The current driver has been validated with
> FPGA burned. We have support for PCIe
> bus, which is used on FPGA prototyping.
>
> The host side of USBSS-DRD controller is compliance
> with XHCI specification, so it works with
> standard XHCI linux driver.
Please line-wrap this properly at 72 columns, like your editor asks you
to when you run git :)
>
> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
> ---
> drivers/usb/Kconfig | 2 +
> drivers/usb/Makefile | 2 +
> drivers/usb/cdns3/Kconfig | 44 +
> drivers/usb/cdns3/Makefile | 14 +
> drivers/usb/cdns3/cdns3-pci-wrap.c | 155 +++
> drivers/usb/cdns3/core.c | 403 ++++++
> drivers/usb/cdns3/core.h | 116 ++
> drivers/usb/cdns3/debug.h | 168 +++
> drivers/usb/cdns3/debugfs.c | 164 +++
> drivers/usb/cdns3/drd.c | 365 +++++
> drivers/usb/cdns3/drd.h | 162 +++
> drivers/usb/cdns3/ep0.c | 907 +++++++++++++
> drivers/usb/cdns3/gadget-export.h | 28 +
> drivers/usb/cdns3/gadget.c | 1985 ++++++++++++++++++++++++++++
> drivers/usb/cdns3/gadget.h | 1207 +++++++++++++++++
> drivers/usb/cdns3/host-export.h | 28 +
> drivers/usb/cdns3/host.c | 72 +
> drivers/usb/cdns3/trace.c | 23 +
> drivers/usb/cdns3/trace.h | 404 ++++++
> 19 files changed, 6249 insertions(+)
> create mode 100644 drivers/usb/cdns3/Kconfig
> create mode 100644 drivers/usb/cdns3/Makefile
> create mode 100644 drivers/usb/cdns3/cdns3-pci-wrap.c
> create mode 100644 drivers/usb/cdns3/core.c
> create mode 100644 drivers/usb/cdns3/core.h
> create mode 100644 drivers/usb/cdns3/debug.h
> create mode 100644 drivers/usb/cdns3/debugfs.c
> create mode 100644 drivers/usb/cdns3/drd.c
> create mode 100644 drivers/usb/cdns3/drd.h
> create mode 100644 drivers/usb/cdns3/ep0.c
> create mode 100644 drivers/usb/cdns3/gadget-export.h
> create mode 100644 drivers/usb/cdns3/gadget.c
> create mode 100644 drivers/usb/cdns3/gadget.h
> create mode 100644 drivers/usb/cdns3/host-export.h
> create mode 100644 drivers/usb/cdns3/host.c
> create mode 100644 drivers/usb/cdns3/trace.c
> create mode 100644 drivers/usb/cdns3/trace.h
This is way too big to try to review all at once. You need to break
this up into logical chunks, each one adding a single functionality to
make it possible to actually review it.
thanks,
greg k-h
next prev parent reply other threads:[~2019-02-04 11:48 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 11:52 [PATCH v3 0/6] Introduced new Cadence USBSS " Pawel Laszczak
2019-01-31 11:52 ` [PATCH v3 1/6] dt-bindings: add binding for USBSS-DRD controller Pawel Laszczak
2019-02-13 22:48 ` Rob Herring
2019-02-14 6:08 ` Pawel Laszczak
2019-02-14 14:00 ` Rob Herring
2019-02-15 1:56 ` Peter Chen
2019-01-31 11:52 ` [PATCH v3 2/6] usb:common Separated decoding functions from dwc3 driver Pawel Laszczak
2019-02-04 11:45 ` Greg KH
2019-02-04 14:17 ` Felipe Balbi
2019-02-04 14:47 ` Greg KH
2019-02-11 12:56 ` Pawel Laszczak
2019-02-11 13:20 ` Felipe Balbi
2019-02-11 13:30 ` Pawel Laszczak
2019-02-05 8:13 ` Pawel Laszczak
2019-02-05 8:25 ` Felipe Balbi
2019-02-04 11:45 ` Greg KH
2019-01-31 11:52 ` [PATCH v3 3/6] usb:common Patch simplify usb_decode_set_clear_feature function Pawel Laszczak
2019-01-31 11:52 ` [PATCH v3 4/6] usb:common Simplify usb_decode_get_set_descriptor function Pawel Laszczak
2019-01-31 12:27 ` Andy Shevchenko
2019-02-04 11:47 ` Greg KH
2019-02-11 12:21 ` Pawel Laszczak
2019-01-31 11:52 ` [PATCH v3 5/6] usb:cdns3 Add Cadence USB3 DRD Driver Pawel Laszczak
2019-02-04 11:48 ` Greg KH [this message]
2019-02-05 8:33 ` Pawel Laszczak
2019-01-31 11:52 ` [PATCH v3 6/6] usb:cdns3 Fix for stuck packets in on-chip OUT buffer Pawel Laszczak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190204114841.GD28608@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jbergsagel@ti.com \
--cc=kurahul@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=pawell@cadence.com \
--cc=peter.chen@nxp.com \
--cc=pjez@cadence.com \
--cc=robh+dt@kernel.org \
--cc=rogerq@ti.com \
--cc=sureshp@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome