From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11CBFC282C4 for ; Mon, 4 Feb 2019 18:04:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E1E6D20820 for ; Mon, 4 Feb 2019 18:04:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729206AbfBDSED (ORCPT ); Mon, 4 Feb 2019 13:04:03 -0500 Received: from muru.com ([72.249.23.125]:37558 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727917AbfBDSED (ORCPT ); Mon, 4 Feb 2019 13:04:03 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 1D5C3808C; Mon, 4 Feb 2019 18:04:11 +0000 (UTC) Date: Mon, 4 Feb 2019 10:03:59 -0800 From: Tony Lindgren To: Roger Quadros Cc: s-anna@ti.com, nsekhar@ti.com, linux-omap@vger.kernel.org, t-kristo@ti.com, nsaulnier@ti.com, jreeder@ti.com, m-karicheri2@ti.com, david@lechnology.com, woods.technical@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] ARM: dts: dra7: add PRU-ICSS modules Message-ID: <20190204180359.GM5720@atomide.com> References: <1549295637-24890-1-git-send-email-rogerq@ti.com> <1549295637-24890-4-git-send-email-rogerq@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1549295637-24890-4-git-send-email-rogerq@ti.com> User-Agent: Mutt/1.11.2 (2019-01-07) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Roger Quadros [190204 15:54]: > --- a/arch/arm/boot/dts/dra7.dtsi > +++ b/arch/arm/boot/dts/dra7.dtsi > @@ -167,6 +167,200 @@ > l4_per3: interconnect@48800000 { > }; > > + pru_icss1: target-module@4b200000 { I suggest you add these into dra7-pruss.dtsi as they have internal interconnects. And eventually some of the *pruss.dtsi files might become shared :) And we avoid moving these around when we define the l3 interconnects and avoid a lot of extra long dtsi line lengths with the added nestedness later on. Regards, Tony