From: Andrew Morton <akpm@linux-foundation.org>
To: Joe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@canonical.com>, Rob Herring <robh@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Dan Williams <dan.j.williams@intel.org>
Subject: Re: [PATCH] checkpatch: Verify SPDX comment style
Date: Tue, 5 Feb 2019 14:21:36 -0800 [thread overview]
Message-ID: <20190205142136.9e7105239919596d0b2b6548@linux-foundation.org> (raw)
In-Reply-To: <8b02899853247a2c67669561761f354dd3bd110e.camel@perches.com>
On Thu, 10 Jan 2019 16:05:11 -0800 Joe Perches <joe@perches.com> wrote:
> Using SPDX commenting style // or /* is specified for
> various file types in Documentation/process/license-rules.rst
> so add an appropriate test for .[chsS] files because many
> proposed file additions and patches do not use the correct style.
Dan's
http://lkml.kernel.org/r/154899811738.3165233.12325692939590944259.stgit@dwillia2-desk3.amr.corp.intel.com
is giving me
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
#500: FILE: mm/shuffle.h:1:
+// SPDX-License-Identifier: GPL-2.0
and switching it to /* */ doesn't fix. This happens with or without
this patch applied. What to do?
next prev parent reply other threads:[~2019-02-05 22:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 0:05 Joe Perches
2019-01-23 11:04 ` Joe Perches
2019-02-05 22:21 ` Andrew Morton [this message]
2019-02-06 2:21 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190205142136.9e7105239919596d0b2b6548@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=dan.j.williams@intel.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®