From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20C4DC169C4 for ; Wed, 6 Feb 2019 10:13:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DDD96218A3 for ; Wed, 6 Feb 2019 10:13:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728859AbfBFKNY (ORCPT ); Wed, 6 Feb 2019 05:13:24 -0500 Received: from foss.arm.com ([217.140.101.70]:50672 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726598AbfBFKNX (ORCPT ); Wed, 6 Feb 2019 05:13:23 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0590680D; Wed, 6 Feb 2019 02:13:23 -0800 (PST) Received: from queper01-lin (queper01-lin.cambridge.arm.com [10.1.195.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 965863F719; Wed, 6 Feb 2019 02:13:20 -0800 (PST) Date: Wed, 6 Feb 2019 10:13:18 +0000 From: Quentin Perret To: Matthias Kaehlcke Cc: "Rafael J . Wysocki" , Viresh Kumar , Matthias Brugger , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Taniya Das , CK Hu , Eddie Huang , Nicolas Boichat , Douglas Anderson Subject: Re: [PATCH 2/2] cpufreq: mediatek: Register an Energy Model Message-ID: <20190206101316.fr7z4ffr4ck4l4aj@queper01-lin> References: <20190205175225.25923-1-mka@chromium.org> <20190205175225.25923-2-mka@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190205175225.25923-2-mka@chromium.org> User-Agent: NeoMutt/20171215 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Matthias, On Tuesday 05 Feb 2019 at 09:52:25 (-0800), Matthias Kaehlcke wrote: > Try and register an Energy Model from mediatek-cpufreq to allow > interested subsystems like the task scheduler to use the provided > information. > > Signed-off-by: Matthias Kaehlcke > --- > drivers/cpufreq/mediatek-cpufreq.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c > index eb8920d398181..e6168ee582783 100644 > --- a/drivers/cpufreq/mediatek-cpufreq.c > +++ b/drivers/cpufreq/mediatek-cpufreq.c > @@ -460,6 +460,8 @@ static int mtk_cpufreq_init(struct cpufreq_policy *policy) > return ret; > } > > + dev_pm_opp_of_register_em(policy->cpus); I'm not familiar with the mediatek-cpufreq driver so bear with me, but the code sets policy->cpus just below here. Is there any particular reason for not using that in PM_EM ? > cpumask_copy(policy->cpus, &info->cpus); > policy->freq_table = freq_table; > policy->driver_data = info; > -- > 2.20.1.611.gfbb209baf1-goog > Thanks, Quentin